Skip to content

existing itemstore not preserved by overrider #2152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shawkins opened this issue Dec 7, 2023 · 1 comment · Fixed by #2154
Closed

existing itemstore not preserved by overrider #2152

shawkins opened this issue Dec 7, 2023 · 1 comment · Fixed by #2154
Assignees
@csviri

Comments

@shawkins
Copy link
Collaborator

shawkins commented Dec 7, 2023

Bug Report

What did you do?

When using ControllerConfigurationOverrider on a controller that has an customized itemStore, it is nulled out.

What did you expect to see?

The original should be preserved.
@csviri csviri self-assigned this Dec 7, 2023
@csviri
Copy link
Collaborator

csviri commented Dec 7, 2023

@shawkins can you elaborate more please, how this happens exactly, you customize the event store with @ControllerConfiguration and then using @ControllerConfigurationOverrider without setting one, then it is nulled out?

shawkins added a commit to shawkins/java-operator-sdk that referenced this issue Dec 7, 2023
@shawkins
fix: preserve the original itemstore
713c54f 
closes: operator-framework#2152

Signed-off-by: Steven Hawkins <[email protected]>
@shawkins shawkins mentioned this issue Dec 7, 2023
Merged
csviri pushed a commit that referenced this issue Dec 7, 2023
@shawkins
fix: preserve the original itemstore (#2154)
da8bba9 
closes: #2152

Signed-off-by: Steven Hawkins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@csviri csviri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: preserve the original itemstore shawkins/java-operator-sdk
2 participants
@shawkins @csviri