Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: preserve the original itemstore #2154

Merged
merged 1 commit into from
Dec 7, 2023
Merged

fix: preserve the original itemstore #2154

merged 1 commit into from
Dec 7, 2023

Conversation

shawkins
Copy link
Collaborator

@shawkins shawkins commented Dec 7, 2023

closes: #2152

@shawkins shawkins requested a review from csviri December 7, 2023 10:44
csviri
csviri approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense :) thx

@csviri csviri merged commit da8bba9 into operator-framework:main Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csviri csviri csviri approved these changes

@adam-sandor adam-sandor Awaiting requested review from adam-sandor

@metacosm metacosm Awaiting requested review from metacosm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

existing itemstore not preserved by overrider
2 participants
@shawkins @csviri