Skip to content

Handling Cluster Scoped Primary Resource in Dependent Resource SecondaryToPrimaryMapper #2311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
csviri opened this issue Mar 25, 2024 · 1 comment · Fixed by #2321
Closed
Milestone

Comments

@csviri
Copy link
Collaborator

csviri commented Mar 25, 2024

Currently by default Dependent Resource assumes that the primary resource is namespace scoped, see:

This is something users have to then handle explicitly, by overriding the SecondaryToPrimaryMapper, see:

#2310 (comment)

In DRs we don't have access to the class of primary to check if it is namespace scoped. But we might create some workarounds, like passing it as a flag for managed resources automatically.

@csviri csviri added this to the 5.0 milestone Mar 25, 2024
metacosm added a commit that referenced this issue Mar 25, 2024
metacosm added a commit that referenced this issue Mar 25, 2024
metacosm added a commit that referenced this issue Mar 25, 2024
metacosm added a commit that referenced this issue Mar 25, 2024
metacosm added a commit that referenced this issue Mar 25, 2024
metacosm added a commit that referenced this issue Mar 26, 2024
Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
metacosm added a commit that referenced this issue Mar 26, 2024
Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
metacosm added a commit that referenced this issue Mar 27, 2024
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
@metacosm
Copy link
Collaborator

Closed by #2321

@csviri csviri closed this as completed Mar 28, 2024
csviri pushed a commit that referenced this issue Apr 10, 2024
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
metacosm added a commit that referenced this issue Apr 10, 2024
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
metacosm added a commit that referenced this issue Apr 11, 2024
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
csviri pushed a commit that referenced this issue May 17, 2024
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
csviri pushed a commit that referenced this issue May 17, 2024
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
csviri pushed a commit that referenced this issue May 21, 2024
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
csviri pushed a commit that referenced this issue Jun 17, 2024
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
metacosm added a commit that referenced this issue Jul 8, 2024
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
metacosm added a commit that referenced this issue Jul 9, 2024
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
metacosm added a commit that referenced this issue Jul 12, 2024
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
csviri pushed a commit that referenced this issue Aug 8, 2024
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
csviri pushed a commit that referenced this issue Aug 15, 2024
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
metacosm added a commit that referenced this issue Aug 29, 2024
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
csviri pushed a commit that referenced this issue Sep 18, 2024
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
csviri pushed a commit that referenced this issue Sep 20, 2024
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
metacosm added a commit that referenced this issue Oct 10, 2024
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
metacosm added a commit that referenced this issue Nov 5, 2024
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
metacosm added a commit that referenced this issue Nov 6, 2024
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
csviri pushed a commit that referenced this issue Nov 13, 2024
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
metacosm added a commit that referenced this issue Nov 19, 2024
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
metacosm added a commit that referenced this issue Nov 20, 2024
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
metacosm added a commit that referenced this issue Nov 27, 2024
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
csviri pushed a commit that referenced this issue Dec 6, 2024
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants