Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: handle clustered resource on secondary to primary mapper init #2321

Merged
merged 1 commit into from
Mar 27, 2024
Merged

feat: handle clustered resource on secondary to primary mapper init #2321

merged 1 commit into from
Mar 27, 2024

Conversation

metacosm
Copy link
Collaborator

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun [email protected]

@metacosm metacosm self-assigned this Mar 26, 2024
@metacosm metacosm requested a review from csviri March 26, 2024 16:51
@openshift-ci openshift-ci bot requested a review from adam-sandor March 26, 2024 16:51
@metacosm metacosm mentioned this pull request Mar 26, 2024
Closed
@metacosm
feat: handle clustered resource on secondary to primary mapper init
577bde1 
Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
csviri
csviri approved these changes Mar 27, 2024
View reviewed changes
Copy link
Collaborator

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

as I mentioned, this is an interesting problem, we can decide later if this solution is good enough or not, but definitely a good improvement.

@csviri csviri linked an issue Mar 27, 2024 that may be closed by this pull request
Handling Cluster Scoped Primary Resource in Dependent Resource SecondaryToPrimaryMapper #2311
Closed
@metacosm metacosm merged commit f62ba49 into next Mar 27, 2024
20 checks passed
@metacosm metacosm deleted the handle-clustered branch March 27, 2024 17:20
@metacosm metacosm mentioned this pull request Mar 27, 2024
Closed
csviri pushed a commit that referenced this pull request Apr 10, 2024
@metacosm @csviri
feat: handle clustered resource on secondary to primary mapper init (#…
5a01704 
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
metacosm added a commit that referenced this pull request Apr 10, 2024
@metacosm
feat: handle clustered resource on secondary to primary mapper init (#…
82bf32a 
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
metacosm added a commit that referenced this pull request Apr 11, 2024
@metacosm
feat: handle clustered resource on secondary to primary mapper init (#…
3610960 
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
csviri pushed a commit that referenced this pull request May 17, 2024
@metacosm @csviri
feat: handle clustered resource on secondary to primary mapper init (#…
803bdd7 
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
csviri pushed a commit that referenced this pull request May 17, 2024
@metacosm @csviri
feat: handle clustered resource on secondary to primary mapper init (#…
e7363e2 
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
csviri pushed a commit that referenced this pull request May 21, 2024
@metacosm @csviri
feat: handle clustered resource on secondary to primary mapper init (#…
6821b16 
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
csviri pushed a commit that referenced this pull request Jun 17, 2024
@metacosm @csviri
feat: handle clustered resource on secondary to primary mapper init (#…
cc5be3f 
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
metacosm added a commit that referenced this pull request Jul 8, 2024
@metacosm
feat: handle clustered resource on secondary to primary mapper init (#…
ada3264 
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
metacosm added a commit that referenced this pull request Jul 9, 2024
@metacosm
feat: handle clustered resource on secondary to primary mapper init (#…
620bf99 
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
metacosm added a commit that referenced this pull request Jul 12, 2024
@metacosm
feat: handle clustered resource on secondary to primary mapper init (#…
f0fe768 
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
csviri pushed a commit that referenced this pull request Aug 8, 2024
@metacosm @csviri
feat: handle clustered resource on secondary to primary mapper init (#…
170774d 
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@csviri csviri mentioned this pull request Aug 14, 2024
Merged
csviri pushed a commit that referenced this pull request Aug 15, 2024
@metacosm @csviri
feat: handle clustered resource on secondary to primary mapper init (#…
ac14a7f 
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
metacosm added a commit that referenced this pull request Aug 29, 2024
@metacosm
feat: handle clustered resource on secondary to primary mapper init (#…
01d470f 
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@csviri csviri mentioned this pull request Sep 17, 2024
Merged
csviri pushed a commit that referenced this pull request Sep 18, 2024
@metacosm @csviri
feat: handle clustered resource on secondary to primary mapper init (#…
17c3be1 
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
csviri pushed a commit that referenced this pull request Sep 20, 2024
@metacosm @csviri
feat: handle clustered resource on secondary to primary mapper init (#…
62befad 
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
metacosm added a commit that referenced this pull request Oct 10, 2024
@metacosm
feat: handle clustered resource on secondary to primary mapper init (#…
879e070 
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
metacosm added a commit that referenced this pull request Nov 5, 2024
@metacosm
feat: handle clustered resource on secondary to primary mapper init (#…
e2acb18 
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
metacosm added a commit that referenced this pull request Nov 6, 2024
@metacosm
feat: handle clustered resource on secondary to primary mapper init (#…
e84be1c 
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
csviri pushed a commit that referenced this pull request Nov 13, 2024
@metacosm @csviri
feat: handle clustered resource on secondary to primary mapper init (#…
ab49b79 
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
metacosm added a commit that referenced this pull request Nov 19, 2024
@metacosm
feat: handle clustered resource on secondary to primary mapper init (#…
3041593 
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
metacosm added a commit that referenced this pull request Nov 20, 2024
@metacosm
feat: handle clustered resource on secondary to primary mapper init (#…
f5f25f2 
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
metacosm added a commit that referenced this pull request Nov 27, 2024
@metacosm
feat: handle clustered resource on secondary to primary mapper init (#…
a87b374 
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
This was referenced Dec 3, 2024
Merged
Closed
csviri pushed a commit that referenced this pull request Dec 6, 2024
@metacosm @csviri
feat: handle clustered resource on secondary to primary mapper init (#…
b40ae17 
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csviri csviri csviri approved these changes

@adam-sandor adam-sandor Awaiting requested review from adam-sandor

Assignees

@metacosm metacosm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handling Cluster Scoped Primary Resource in Dependent Resource SecondaryToPrimaryMapper
2 participants
@metacosm @csviri