-
Notifications
You must be signed in to change notification settings - Fork 551
Use of/gini instead of inifrance/gini #2331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use of/gini instead of inifrance/gini #2331
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kevinrizza The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Interesting:
|
It looks like there's some ordering that |
The github.com/irifrance/gini package has been purged from github An existing version that preserved that history has been forked to the operator-framework org, and this commit updates that dependency to use the forked version. Signed-off-by: kevinrizza <[email protected]>
bac2f08
to
0cc2135
Compare
@timflannagan should be fixed now |
/lgtm |
The github.com/irifrance/gini package has been purged from github An existing version that preserved that history has been forked to the operator-framework org, and this commit updates that dependency to use the forked version. Signed-off-by: kevinrizza <[email protected]>
This is a roundabout workaround for this issue in OLM: operator-framework/operator-lifecycle-manager#2322 The issue was technically fixed with the v0.19.1 release with the following PRs: operator-framework/operator-lifecycle-manager#2331 operator-framework/operator-lifecycle-manager#2336 ...however, trying to update the dependency on OLM in ocs-operator leads to the following issue: red-hat-storage/ocs-operator#1426 The addition of a default GOPROXY lets us access a cached version of this package that no longer exists. Go is wonderful, folks. Signed-off-by: Jose A. Rivera <[email protected]>
This is a roundabout workaround for this issue in OLM: operator-framework/operator-lifecycle-manager#2322 The issue was technically fixed with the v0.19.1 release with the following PRs: operator-framework/operator-lifecycle-manager#2331 operator-framework/operator-lifecycle-manager#2336 ...however, trying to update the dependency on OLM in ocs-operator leads to the following issue: red-hat-storage/ocs-operator#1426 The addition of a default GOPROXY lets us access a cached version of this package that no longer exists. Go is wonderful, folks. Signed-off-by: Jose A. Rivera <[email protected]>
This is a roundabout workaround for this issue in OLM: operator-framework/operator-lifecycle-manager#2322 The issue was technically fixed with the v0.19.1 release with the following PRs: operator-framework/operator-lifecycle-manager#2331 operator-framework/operator-lifecycle-manager#2336 ...however, trying to update the dependency on OLM in ocs-operator leads to the following issue: red-hat-storage/ocs-operator#1426 The addition of a default GOPROXY lets us access a cached version of this package that no longer exists. Go is wonderful, folks. Signed-off-by: Jose A. Rivera <[email protected]>
This is a roundabout workaround for this issue in OLM: operator-framework/operator-lifecycle-manager#2322 The issue was technically fixed with the v0.19.1 release with the following PRs: operator-framework/operator-lifecycle-manager#2331 operator-framework/operator-lifecycle-manager#2336 ...however, trying to update the dependency on OLM in ocs-operator leads to the following issue: red-hat-storage/ocs-operator#1426 The addition of a default GOPROXY lets us access a cached version of this package that no longer exists. Go is wonderful, folks. Signed-off-by: Jose A. Rivera <[email protected]>
The github.com/irifrance/gini package has been purged from github. An existing version that preserved that history has been forked to the operator-framework org, and this commit updates that dependency to use the forked version.
In the future, we should investigate https://github.com/go-air/gini if and when it creates consumable releases, as it appears that the maintainer of the missing package is now maintaining the package there.
Resolves #2322