Bump gini for performance improvement #2336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
new version has logic.C performance improvements that should help see: - go-air/gini#17 - go-air/gini@3a1a4d9 - go-air/gini@8dd6805 - go-air/gini#18 Signed-off-by: Evan <[email protected]>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinhxuanvu, ecordell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jarrpa
added a commit
to jarrpa/odf-operator
that referenced
this pull request
Dec 13, 2021
This is a roundabout workaround for this issue in OLM: operator-framework/operator-lifecycle-manager#2322 The issue was technically fixed with the v0.19.1 release with the following PRs: operator-framework/operator-lifecycle-manager#2331 operator-framework/operator-lifecycle-manager#2336 ...however, trying to update the dependency on OLM in ocs-operator leads to the following issue: red-hat-storage/ocs-operator#1426 The addition of a default GOPROXY lets us access a cached version of this package that no longer exists. Go is wonderful, folks. Signed-off-by: Jose A. Rivera <[email protected]>
jarrpa
added a commit
to jarrpa/odf-operator
that referenced
this pull request
Dec 13, 2021
This is a roundabout workaround for this issue in OLM: operator-framework/operator-lifecycle-manager#2322 The issue was technically fixed with the v0.19.1 release with the following PRs: operator-framework/operator-lifecycle-manager#2331 operator-framework/operator-lifecycle-manager#2336 ...however, trying to update the dependency on OLM in ocs-operator leads to the following issue: red-hat-storage/ocs-operator#1426 The addition of a default GOPROXY lets us access a cached version of this package that no longer exists. Go is wonderful, folks. Signed-off-by: Jose A. Rivera <[email protected]>
jarrpa
added a commit
to jarrpa/odf-operator
that referenced
this pull request
Jun 17, 2022
This is a roundabout workaround for this issue in OLM: operator-framework/operator-lifecycle-manager#2322 The issue was technically fixed with the v0.19.1 release with the following PRs: operator-framework/operator-lifecycle-manager#2331 operator-framework/operator-lifecycle-manager#2336 ...however, trying to update the dependency on OLM in ocs-operator leads to the following issue: red-hat-storage/ocs-operator#1426 The addition of a default GOPROXY lets us access a cached version of this package that no longer exists. Go is wonderful, folks. Signed-off-by: Jose A. Rivera <[email protected]>
jarrpa
added a commit
to jarrpa/odf-operator
that referenced
this pull request
Jul 13, 2022
This is a roundabout workaround for this issue in OLM: operator-framework/operator-lifecycle-manager#2322 The issue was technically fixed with the v0.19.1 release with the following PRs: operator-framework/operator-lifecycle-manager#2331 operator-framework/operator-lifecycle-manager#2336 ...however, trying to update the dependency on OLM in ocs-operator leads to the following issue: red-hat-storage/ocs-operator#1426 The addition of a default GOPROXY lets us access a cached version of this package that no longer exists. Go is wonderful, folks. Signed-off-by: Jose A. Rivera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new version has logic.C performance improvements that speed up input construction a little.
I added a new benchmark for input construction and tested it before/after the update:
Before:
After:
refs:
(I missed the discussion around forking into operator-framework - is there any reason not to switch back to the upstream here?)