Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing webhook e2e test #2419

Conversation

awgreene
Copy link
Member

This commit introduces a change to the webhook tests that rely on
a grpc catalogSource that is stored in an off cluster registry.
These tests originally required that the following happen within a
minute:

  1. The catalogSource is installed and ready to serve.
  2. The contents of the bundle are unpacked and placed in an
    installPlan.
  3. The CSV is installed and in the ready state.

The tests will now wait for the catalogSource to be ready to serve
before moving onto steps 2 and 3.

@openshift-ci
Copy link

openshift-ci bot commented Oct 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2021
@timflannagan
Copy link
Member

/lgtm

@awgreene
Copy link
Member Author

/hold
Planning to apply this change in multiple locations where grpc catalogsSources are being created from off cluster registries.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2021
@awgreene awgreene force-pushed the fix-failing-webhook-test branch from 15b7dc1 to e539f26 Compare October 11, 2021 22:37
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2021
@awgreene
Copy link
Member Author

/retest

@awgreene awgreene force-pushed the fix-failing-webhook-test branch 2 times, most recently from 8c8baaf to 9c2b51a Compare October 12, 2021 16:19
This commit introduces a change to the e2e tests that rely on
a grpc catalogSource that is stored in an off cluster registry.
These tests originally required that the following happen within a
minute:

1. The catalogSource is installed and ready to serve.
2. The contents of the bundle are unpacked and placed in an
installPlan.
3. The CSV is installed and in the ready state.

The tests will now wait for the catalogSource to be ready to serve
before moving onto steps 2 and 3.

Signed-off-by: Alexander Greene <[email protected]>
@awgreene awgreene force-pushed the fix-failing-webhook-test branch from 9c2b51a to aacdf16 Compare October 12, 2021 16:41
@timflannagan
Copy link
Member

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 12, 2021
@awgreene
Copy link
Member Author

None of the failed e2e tests seem related:

[Fail] Operator Group [It] static provider 
/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/vendor/github.com/stretchr/testify/require/require.go:1231

[Fail] Subscription [It] creation with pod config 
/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/vendor/github.com/stretchr/testify/assert/assertion_format.go:714

[Fail] Install Plan when an InstallPlan is created with no valid OperatorGroup present [It] should clear clear up the condition in the InstallPlan status that contains an error message when a valid OperatorGroup is created 
/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/installplan_e2e_test.go:3242

[Fail] CRD Versions [It] blocks a CRD upgrade that could cause data loss 
/home/runner/work/operator-lifecycle-manager/operator-lifecycle-manager/test/e2e/crd_e2e_test.go:218

/retest

@timflannagan
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2021
@openshift-merge-robot openshift-merge-robot merged commit 700d282 into operator-framework:master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
3 participants