-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing webhook e2e test #2419
Fix failing webhook e2e test #2419
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awgreene The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/hold |
15b7dc1
to
e539f26
Compare
/retest |
8c8baaf
to
9c2b51a
Compare
This commit introduces a change to the e2e tests that rely on a grpc catalogSource that is stored in an off cluster registry. These tests originally required that the following happen within a minute: 1. The catalogSource is installed and ready to serve. 2. The contents of the bundle are unpacked and placed in an installPlan. 3. The CSV is installed and in the ready state. The tests will now wait for the catalogSource to be ready to serve before moving onto steps 2 and 3. Signed-off-by: Alexander Greene <[email protected]>
9c2b51a
to
aacdf16
Compare
/hold cancel |
None of the failed e2e tests seem related:
/retest |
/lgtm |
This commit introduces a change to the webhook tests that rely on
a grpc catalogSource that is stored in an off cluster registry.
These tests originally required that the following happen within a
minute:
installPlan.
The tests will now wait for the catalogSource to be ready to serve
before moving onto steps 2 and 3.