Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-32439: Fix: Ensure jobs without unpack label are considered #3262

Merged
merged 1 commit into from
May 29, 2024

Conversation

varshaprasad96
Copy link
Member

Description of the change:
If an unpacked job without the relevant unpack label exists, then proceed with the install steps.

Motivation for the change:
In previous versions of OLM, the unpack label in jobs was not set. Which means - if there is a job existing on cluster which already has unpacked contents, and OLM tries installing the same operator, we error out.

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@openshift-ci openshift-ci bot requested review from anik120 and dtfranz May 17, 2024 22:17
@varshaprasad96
Copy link
Member Author

cc: @dtfranz could you please take a look?

@dtfranz
Copy link
Contributor

dtfranz commented May 17, 2024

I'm assuming the olmlog.txt file was accidental? 😄

@varshaprasad96
Copy link
Member Author

Addressed the changes. The previous e2e failures didn't seem to be related to the changes, hoping that it passes CI.

@varshaprasad96 varshaprasad96 requested a review from dtfranz May 20, 2024 17:53
@perdasilva
Copy link
Collaborator

Any unit tests we can add to make sure we don't regress?

Copy link
Collaborator

@perdasilva perdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spoke to Dev, there will be follow up PRs for test. Need this in master to unblock.

@dtfranz dtfranz enabled auto-merge May 29, 2024 17:51
@dtfranz dtfranz added this pull request to the merge queue May 29, 2024
Merged via the queue into master with commit 01b44e8 May 29, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants