Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpack Job Creation Failure Test #3297

Merged
merged 1 commit into from
May 31, 2024

Conversation

dtfranz
Copy link
Contributor

@dtfranz dtfranz commented May 29, 2024

Extends an existing unit test to cover the scenario where an old, failed job missing the label added in later OLM versions is not found with the filtered list call, resulting in an 'AlreadyExists' error when the new job is created.

Addresses this comment:
#3262 (comment)

Test fail before #3262 merge here

Test pass after merge here

@openshift-ci openshift-ci bot requested review from ankitathomas and joelanford May 29, 2024 17:46
Extends an existing unit test to cover the scenario where an old, failed job missing the label added in later OLM versions is not found with the filtered list call, resulting in an 'AlreadyExists' error when the new job is created.

Signed-off-by: Daniel Franz <[email protected]>
@dtfranz dtfranz force-pushed the job-unpack-test branch from 971e115 to c627ca5 Compare May 29, 2024 20:11
Copy link
Collaborator

@perdasilva perdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ^^ thank you!!

@perdasilva perdasilva added this pull request to the merge queue May 31, 2024
Merged via the queue into operator-framework:master with commit 8751ca0 May 31, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants