Skip to content

Do not expose pkg/scaffold #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
estroz opened this issue Nov 16, 2018 · 0 comments · Fixed by #1182
Closed

Do not expose pkg/scaffold #756

estroz opened this issue Nov 16, 2018 · 0 comments · Fixed by #1182
Assignees
@estroz
Labels
needs discussion

Comments

@estroz
Copy link
Member

estroz commented Nov 16, 2018 •
edited by hasbro17
Loading

Problem
As per #160, specifically this issue comment, users are not going to need pkg/scaffold as a library, so it should not be exported.

Proposed fix
Move pkg/scaffold -> internal/scaffold.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@estroz estroz

Labels
needs discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pkg/scaffold: move to internal/pkg/scaffold joelanford/operator-sdk
2 participants
@joelanford @estroz