-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Symlink internal dir in e2e #871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symlink internal dir in e2e #871
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to handle the scaffold constants better here? I'm worried that if we change a filename in our scaffolds, we might forget to do it in internal, which could break something. Hopefully E2E would catch that, but it's still possible that something would slip through a crack.
@AlexNPavel while scaffold constants should be used wherever possible to prevent code drift, they change infrequently enough that having |
I guess it's fine to leave the constants as they are. As you said, they shouldn't change often. And other solutions are a bit cumbersome. |
47164f7
to
58edae5
Compare
Just a thought, but #756 is potentially related to this issue. If we moved |
@joelanford yes. We can have I will scrap the constants part of this PR in favor of restructuring and stick with just symlinking |
58edae5
to
2ce77cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of the change: symlink both
pkg
andinternal
dirs to the test project'svendor
when running e2e tests locally, and some cleanup.Motivation for the change: the e2e tests symlink
internal
so any future changes are picked up by local e2e tests.