pkg/scaffold: move to internal/pkg/scaffold #1182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/L
openshift-ci-robot
added
the
needs-rebase
openshift-ci-robot
removed
the
needs-rebase
joelanford
changed the title
lilic
suggested changes
Mar 20, 2019
There was a problem hiding this comment.
We should update the link as well to point to the newly moved file. -> https://raw.githubusercontent.com/operator-framework/operator-sdk/f5d68dbc68b919ac1cf179faf2110fb672473f98/doc/user/logging.md
|
/test marker |
|
@estroz are you referring to the flaky marker test (now looks ok) or something else? |
|
The marker test. Didn't know it was flaky 🤕. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Moving
pkg/scaffoldtointernal/pkg/scaffoldMotivation for the change:
Necessary for 1.0.0 release and closes #756