Skip to content

Fixed CLI option to specify namespace-manifests #1243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fixed CLI option to specify namespace-manifests #1243

wants to merge 1 commit into from

Conversation

jpkrohling
Copy link

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 26, 2019
lilic
lilic approved these changes Mar 26, 2019
View reviewed changes
Copy link
Member

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! lgtm

@hasbro17
Copy link
Contributor

/cc @AlexNPavel

@AlexNPavel
Copy link
Contributor

I think this is actually a typo in the code. The flag was supposed to be the same as the one for the test subcommands, which both use namespaced-manifest. I'm not sure if we should change that in the scorecard code though, since that would be a (minor) breaking change.

@joelanford
Copy link
Member

@AlexNPavel since we're still pre-1.0 and will be making some breaking changes, I don't see an issue with fixing the typo and documenting the breaking change in the CHANGELOG.

@AlexNPavel AlexNPavel mentioned this pull request Mar 29, 2019
Merged
@joelanford
Copy link
Member

/hold

We're going to resolve this by changing the flag in #1266

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilic lilic lilic approved these changes

@hasbro17 hasbro17 Awaiting requested review from hasbro17

@joelanford joelanford Awaiting requested review from joelanford

@AlexNPavel AlexNPavel Awaiting requested review from AlexNPavel

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jpkrohling @hasbro17 @AlexNPavel @joelanford @lilic @openshift-ci-robot