Skip to content

cmd/.../scorecard: change namespaced-manifest flag #1266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2019
Merged

cmd/.../scorecard: change namespaced-manifest flag #1266

merged 1 commit into from
Apr 1, 2019

Conversation

AlexNPavel
Copy link
Contributor

Description of the change: Change namespace-manifest flag in scorecard to namespaced-manifest flag.

Motivation for the change: Match other commands like test local and build. Closes #1243

@AlexNPavel AlexNPavel added the scorecard Issue relates to the scorecard subcomponent label Mar 29, 2019
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 29, 2019
estroz
estroz approved these changes Mar 29, 2019
View reviewed changes
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2019
lilic
lilic approved these changes Apr 1, 2019
View reviewed changes
Copy link
Member

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

joelanford
joelanford approved these changes Apr 1, 2019
View reviewed changes
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joelanford joelanford mentioned this pull request Apr 1, 2019
Closed
@AlexNPavel AlexNPavel merged commit eea4261 into operator-framework:master Apr 1, 2019
@AlexNPavel AlexNPavel deleted the fix-flag branch April 1, 2019 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelanford joelanford joelanford approved these changes

@lilic lilic lilic approved these changes

@estroz estroz estroz approved these changes

@shawn-hurley shawn-hurley Awaiting requested review from shawn-hurley

@hasbro17 hasbro17 Awaiting requested review from hasbro17

@theishshah theishshah Awaiting requested review from theishshah

Assignees

@estroz estroz

Labels
lgtm Indicates that a PR is ready to be merged. scorecard Issue relates to the scorecard subcomponent size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AlexNPavel @joelanford @lilic @estroz @openshift-ci-robot