-
Notifications
You must be signed in to change notification settings - Fork 1.8k
bump controller-tools to v0.2.0 #1642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump controller-tools to v0.2.0 #1642
Conversation
ba3db71
to
c49ecbb
Compare
c86b140
to
8f7bfbd
Compare
Two changes that need discussion:
|
@estroz For .1 I think we should follow the convention that kubebuilder has, so it will make it easier to migrate, do they have anything established already? For 2. I think the log about the deprecation and error out if spec is not met, sounds good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update the CHANGELOG.
@hasbro17 if you are the one doing the migration guide we should make a note of the versions/version in there as well.
Otherwise lgtm
9576718
to
6d4d6c3
Compare
CRD file naming changes were quite extensive and touched both Helm and Ansible docs/tests. PTAL. /cc @lilic @hasbro17 @AlexNPavel @joelanford @jmrodri @fabianvf |
237857f
to
90d0b3f
Compare
@lilic kubebuilder would generate a CRD file name |
Since we are moving to kubebuilder at some point, I would suggest we go the kubebuilder way as we probably will have to change it then anyways. |
26bcf4b
to
3b49157
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4d330f3
into
operator-framework:refactor/controller-runtime-v0.2.0
Description of the change: bump controller-tools to v0.2.0 and update CRD generator API/unit tests.
Motivation for the change: controller-tools k8s deps versions should match those of controller-runtime when possible. #1143 requires some changes in this release too.
Note: #1607 should be closed once the refactor base branch is merged with master.