Skip to content

(c-r v0.2.0) *: update CRD manifest file names to <full group>_<resource>_crd.yaml #1784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

estroz
Copy link
Member

@estroz estroz commented Aug 5, 2019

Description of the change: CRD manifest name changes from #1642.

Motivation for the change: a CRD manifest can contain multiple API versions. Naming must change to reflect only the group and kind represented by that CRD.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 5, 2019
@estroz
Copy link
Member Author

estroz commented Aug 8, 2019

Depends on #1782 being merged into refactor branch.

Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hasbro17 hasbro17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after nits.

@estroz estroz merged commit 922f52f into operator-framework:refactor/controller-runtime-v0.2.0 Aug 10, 2019
@estroz estroz deleted the cr-crd-name-format-cr-v0.2.0 branch August 10, 2019 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants