-
Notifications
You must be signed in to change notification settings - Fork 1.8k
(c-r v0.2.0) *: update CRD manifest file names to <full group>_<resource>_crd.yaml #1784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
estroz
merged 6 commits into
operator-framework:refactor/controller-runtime-v0.2.0
from
estroz:cr-crd-name-format-cr-v0.2.0
Aug 10, 2019
Merged
(c-r v0.2.0) *: update CRD manifest file names to <full group>_<resource>_crd.yaml #1784
estroz
merged 6 commits into
operator-framework:refactor/controller-runtime-v0.2.0
from
estroz:cr-crd-name-format-cr-v0.2.0
Aug 10, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depends on #1782 being merged into refactor branch. |
joelanford
reviewed
Aug 9, 2019
joelanford
approved these changes
Aug 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hasbro17
reviewed
Aug 10, 2019
hasbro17
reviewed
Aug 10, 2019
hasbro17
approved these changes
Aug 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after nits.
922f52f
into
operator-framework:refactor/controller-runtime-v0.2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change: CRD manifest name changes from #1642.
Motivation for the change: a CRD manifest can contain multiple API versions. Naming must change to reflect only the group and kind represented by that CRD.