docs: Add steps for sdk key init #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msohailhussain
approved these changes
Apr 7, 2020
README.md
Outdated
| @@ -32,7 +32,17 @@ Create the Optimizely client, for example: | |||
| $optimizely = new Optimizely(<<DATAFILE>>); | |||
| ``` | |||
|
|
|||
| You can also provide an implementation of the `ProjectConfigManagerInterface` in the constructor: | |||
| Or you may also use OptimizelyFactory method to create an optimizely client using your SDK key and an optional fallback datafile. Using this method internally creates an HTTPProjectConfigManager. See HTTPProjectConfigManager for further detail. | |||
There was a problem hiding this comment.
Please link HTTPProjectConfigManager to actual github file.
README.md
Outdated
| ``` | ||
| $optimizelyClient = OptimizelyFactory::createDefaultInstance("your-sdk-key", <<DATAFILE>>); | ||
| ``` | ||
| // access your HTTPProjectConfigManager |
There was a problem hiding this comment.
that's typo, should come under coding panel.
README.md
Outdated
| $configManager = $optimizelyClient->configManager; | ||
| ``` | ||
|
|
||
| Or you can also provide an implementation of the `ProjectConfigManagerInterface` in the constructor: |
There was a problem hiding this comment.
Please link ProjectConfigManagerInterface to actual github file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This updates readme for factory method introduced in #189
Test plan
All checks continue to pass.
Issues