Skip to content

docs: Add steps for sdk key init #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 8, 2020
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,17 @@ Create the Optimizely client, for example:
$optimizely = new Optimizely(<<DATAFILE>>);
```

You can also provide an implementation of the `ProjectConfigManagerInterface` in the constructor:
Or you may also use OptimizelyFactory method to create an optimizely client using your SDK key and an optional fallback datafile. Using this method internally creates an HTTPProjectConfigManager. See HTTPProjectConfigManager for further detail.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link HTTPProjectConfigManager to actual github file.


```
$optimizelyClient = OptimizelyFactory::createDefaultInstance("your-sdk-key", <<DATAFILE>>);
```
// access your HTTPProjectConfigManager
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's typo, should come under coding panel.

```
$configManager = $optimizelyClient->configManager;
```

Or you can also provide an implementation of the `ProjectConfigManagerInterface` in the constructor:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link ProjectConfigManagerInterface to actual github file.


```
$configManager = new HTTPProjectConfigManager(<<SDK_KEY>>);
Expand Down