Skip to content

Panic in GetInstanceByNodeName() #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jhorwit2 opened this issue Apr 4, 2018 · 0 comments
Closed

Panic in GetInstanceByNodeName() #167

jhorwit2 opened this issue Apr 4, 2018 · 0 comments
Assignees
@prydie
Labels
bug
Milestone
0.3.2

Comments

@jhorwit2
Copy link
Member

jhorwit2 commented Apr 4, 2018 

E0404 17:01:53.996746     449 runtime.go:66] Observed a panic: "invalid memory address or nil pointer dereference" (runtime error: invalid memory address or nil pointer dereference)
/go/src/github.com/oracle/oci-cloud-controller-manager/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:72
/go/src/github.com/oracle/oci-cloud-controller-manager/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:65
/go/src/github.com/oracle/oci-cloud-controller-manager/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:51
/usr/local/go/src/runtime/asm_amd64.s:509
/usr/local/go/src/runtime/panic.go:491
/usr/local/go/src/runtime/panic.go:63
/usr/local/go/src/runtime/signal_unix.go:367
/go/src/github.com/oracle/oci-cloud-controller-manager/pkg/oci/client/compute.go:174
/go/src/github.com/oracle/oci-cloud-controller-manager/pkg/oci/instances.go:115
/go/src/github.com/oracle/oci-cloud-controller-manager/vendor/k8s.io/kubernetes/pkg/controller/cloud/node_controller.go:420
/go/src/github.com/oracle/oci-cloud-controller-manager/vendor/k8s.io/kubernetes/pkg/controller/cloud/node_controller.go:155
/go/src/github.com/oracle/oci-cloud-controller-manager/vendor/k8s.io/kubernetes/pkg/controller/cloud/node_controller.go:142
/go/src/github.com/oracle/oci-cloud-controller-manager/vendor/k8s.io/kubernetes/pkg/controller/cloud/node_controller.go:121
/go/src/github.com/oracle/oci-cloud-controller-manager/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:133
/go/src/github.com/oracle/oci-cloud-controller-manager/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:134
/go/src/github.com/oracle/oci-cloud-controller-manager/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:88
/usr/local/go/src/runtime/asm_amd64.s:2337
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x14ac6c2]

goroutine 131 [running]:
github.com/oracle/oci-cloud-controller-manager/vendor/k8s.io/apimachinery/pkg/util/runtime.HandleCrash(0x0, 0x0, 0x0)
	/go/src/github.com/oracle/oci-cloud-controller-manager/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:58 +0x111
panic(0x16a2c80, 0x2625af0)
	/usr/local/go/src/runtime/panic.go:491 +0x283
github.com/oracle/oci-cloud-controller-manager/pkg/oci/client.(*client).GetInstanceByNodeName(0xc4200a74c0, 0x24c3ca0, 0xc42001c050, 0xc4206882c0, 0x31, 0x1, 0xc420734e80, 0x10)
	/go/src/github.com/oracle/oci-cloud-controller-manager/pkg/oci/client/compute.go:174 +0x442
github.com/oracle/oci-cloud-controller-manager/pkg/oci.(*CloudProvider).ExternalID(0xc4209fe050, 0x24c3ca0, 0xc42001c050, 0xc4206882c0, 0x31, 0x0, 0x24a2620, 0xc4205d3c40, 0xc4203ee3c0)
	/go/src/github.com/oracle/oci-cloud-controller-manager/pkg/oci/instances.go:115 +0x159
github.com/oracle/oci-cloud-controller-manager/vendor/k8s.io/kubernetes/pkg/controller/cloud.ensureNodeExistsByProviderIDOrExternalID(0x24c8f40, 0xc4209fe050, 0xc4205a9480, 0x0, 0x1, 0x1)
	/go/src/github.com/oracle/oci-cloud-controller-manager/vendor/k8s.io/kubernetes/pkg/controller/cloud/node_controller.go:420 +0xef
github.com/oracle/oci-cloud-controller-manager/vendor/k8s.io/kubernetes/pkg/controller/cloud.(*CloudNodeController).updateNodeAddress(0xc4205baeb0, 0xc4205a9480, 0x24c8f40, 0xc4209fe050)
	/go/src/github.com/oracle/oci-cloud-controller-manager/vendor/k8s.io/kubernetes/pkg/controller/cloud/node_controller.go:155 +0x9b
github.com/oracle/oci-cloud-controller-manager/vendor/k8s.io/kubernetes/pkg/controller/cloud.(*CloudNodeController).UpdateNodeStatus(0xc4205baeb0)
	/go/src/github.com/oracle/oci-cloud-controller-manager/vendor/k8s.io/kubernetes/pkg/controller/cloud/node_controller.go:142 +0x15c
github.com/oracle/oci-cloud-controller-manager/vendor/k8s.io/kubernetes/pkg/controller/cloud.(*CloudNodeController).UpdateNodeStatus-fm()
	/go/src/github.com/oracle/oci-cloud-controller-manager/vendor/k8s.io/kubernetes/pkg/controller/cloud/node_controller.go:121 +0x2a
github.com/oracle/oci-cloud-controller-manager/vendor/k8s.io/apimachinery/pkg/util/wait.JitterUntil.func1(0xc4207b02d0)
	/go/src/github.com/oracle/oci-cloud-controller-manager/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:133 +0x5e
github.com/oracle/oci-cloud-controller-manager/vendor/k8s.io/apimachinery/pkg/util/wait.JitterUntil(0xc4207b02d0, 0x45d964b800, 0x0, 0xc42066a701, 0xc420086120)
	/go/src/github.com/oracle/oci-cloud-controller-manager/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:134 +0xbd
github.com/oracle/oci-cloud-controller-manager/vendor/k8s.io/apimachinery/pkg/util/wait.Until(0xc4207b02d0, 0x45d964b800, 0xc420086120)
	/go/src/github.com/oracle/oci-cloud-controller-manager/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:88 +0x4d
created by github.com/oracle/oci-cloud-controller-manager/vendor/k8s.io/kubernetes/pkg/controller/cloud.(*CloudNodeController).Run
	/go/src/github.com/oracle/oci-cloud-controller-manager/vendor/k8s.io/kubernetes/pkg/controller/cloud/node_controller.go:121 +0xca

Seems to be here and related to the oci client update

cc @prydie
@prydie prydie changed the title Entering the wrong compartment id in the config causes panic on fetch node addresses Panic in GetInstanceByNodeName() Apr 5, 2018
@prydie prydie added the bug label Apr 5, 2018
@prydie prydie added this to the 0.3.2 milestone Apr 5, 2018
@prydie prydie self-assigned this Apr 5, 2018
prydie added a commit that referenced this issue Apr 5, 2018
@prydie
Add nil checks in GetInstanceByNodeName()
f673ba1 
Previously the CCM would panic when vnic.PublicIp or vnic.HostnameLabel
were nil.

Fixes: #167
@prydie prydie mentioned this issue Apr 5, 2018
Merged
prydie added a commit that referenced this issue Apr 5, 2018
@prydie
Add nil checks in GetInstanceByNodeName() (#173)
9908ebf 
Previously the CCM would panic when vnic.PublicIp or vnic.HostnameLabel
were nil.

Fixes: #167
ayushverma14 pushed a commit to ayushverma14/oci-cloud-controller-manager that referenced this issue Jul 18, 2022
@prydie @ayushverma14
Add nil checks in GetInstanceByNodeName() (oracle#173)
5129c2c 
Previously the CCM would panic when vnic.PublicIp or vnic.HostnameLabel
were nil.

Fixes: oracle#167
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prydie prydie

Labels
bug
Projects
None yet
Milestone
0.3.2
Development

No branches or pull requests
2 participants
@prydie @jhorwit2