Add nil checks in GetInstanceByNodeName() #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the CCM would panic when vnic.PublicIp or vnic.HostnameLabel were nil. Fixes: #167
|
LGTM however there are a lot of other places we dereference pointers without nil checks. We should probably audit our usage to be more defensive. |
jhorwit2
approved these changes
Apr 5, 2018
l-technicore
pushed a commit
to l-technicore/oci-cloud-controller-manager
that referenced
this pull request
Jun 14, 2022
…m task/OKE-16774 to internal * commit 'b53bb3c4abc113be229c65b17e0567109a0c8972': OKE-16774: Adding error condition when in transit is on and attachment type is iscsi
ayushverma14
pushed a commit
to ayushverma14/oci-cloud-controller-manager
that referenced
this pull request
Jul 18, 2022
Previously the CCM would panic when vnic.PublicIp or vnic.HostnameLabel were nil. Fixes: oracle#167
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the SDK upgrade the CCM would panic when either
vnic.PublicIporvnic.HostnameLabelwere nil.Fixes: #167