Port Service E2E tests from core #115

prydie · 2018-01-15T17:40:11Z

Implements a stripped down version of the Service mutability test from the Kubernetes core E2E test suite using a modified subset of the test machinery from core.

prydie · 2018-01-17T16:44:49Z

@owainlewis Note dependency change

prydie · 2018-02-23T17:53:09Z

docs/development.md

   go test -timeout 45m -v ./test/integration/loadbalancer
 ```

+


jhorwit2

Did an initial pass. I'm guessing you got most of these tests from core? If so i'm not gonna review them in depth. Did you change any?

jhorwit2 · 2018-02-25T23:54:14Z

pkg/oci/load_balancer_security_lists.go

+	)
+
+	for _, subnet = range nodeSubnets {
+		err := wait.ExponentialBackoff(retry.DefaultBackoff, func() (bool, error) {


Why add backoff here? We should let the controller handle it that way other services have a chance to be updated if the current one errors out.

I initially added it in to make the integration tests pass again. Will remove now focusing on E2E tests.

jhorwit2 · 2018-02-25T23:55:04Z

pkg/oci/load_balancer_security_lists.go

-			return fmt.Errorf("get security list for subnet `%s`: %v", subnet.ID, err)
-		}
+	var (
+		lastErr error


From what I see you don't need lastErr

jhorwit2 · 2018-02-25T23:56:27Z

test/e2e/framework/framework.go

+	if err := wait.PollImmediate(Poll, 30*time.Second, func() (bool, error) {
+		var err error
+		got, err = f.ClientSet.CoreV1().Namespaces().Create(namespaceObj)
+		if err != nil {


This will never exit if the namespace is created. You should check for already exists error.

Is it possible to get an already exists error when using GenerateName?

jhorwit2 · 2018-02-25T23:57:12Z

test/e2e/framework/framework.go

+func (f *Framework) DeleteNamespace(namespace string, timeout time.Duration) error {
+	startTime := time.Now()
+	if err := f.ClientSet.CoreV1().Namespaces().Delete(namespace, nil); err != nil {
+		return err


You should return nil here if the namespace wasn't found.

jhorwit2 · 2018-02-25T23:58:41Z

test/e2e/framework/framework.go

+			for _, ns := range f.namespacesToDelete {
+				By(fmt.Sprintf("Destroying namespace %q for this suite.", ns.Name))
+				if err := f.DeleteNamespace(ns.Name, 5*time.Minute); err != nil {
+					if !apierrors.IsNotFound(err) {


Returning nil in DeleteNamespace when it's NotFound cleans this up.

jhorwit2 · 2018-02-26T00:01:35Z

test/e2e/framework/networking_utils.go

+
+	ipPort := net.JoinHostPort(ip, strconv.Itoa(port))
+	url := fmt.Sprintf("http://%s%s", ipPort, request)
+	if ip == "" {


nit: you should check these errors before you make the url

jhorwit2 · 2018-02-26T00:03:37Z

test/e2e/framework/networking_utils.go

+	return false, nil
+}
+
+func TestReachableUDP(ip string, port int, request string, expect string) (bool, error) {


Is this used since OCI doesn't support UDP?

jhorwit2 · 2018-02-26T00:04:05Z

test/e2e/framework/networking_utils.go

+	con, err := net.Dial("udp", ipPort)
+	if err != nil {
+		return false, fmt.Errorf("Failed to dial %s: %v", ipPort, err)
+	}


I think you're missing defer con.Close(). This goes for all these tests.

Makes sense to me. I copied this over from core; probably should be fixed there too.

jhorwit2 · 2018-02-26T00:06:18Z

test/e2e/load_balancer_test.go

+		By("checking the TCP LoadBalancer is closed")
+		jig.TestNotReachableHTTP(tcpIngressIP, svcPort, loadBalancerLagTimeout)
+	})
+})


We should create a ticket to track testing preserving the source ip once OCI supports tcp proxy protocol.

jhorwit2 · 2018-02-26T00:06:46Z

test/integration/loadbalancer/loadbalancer_test.go

+			return nil
+		}
+	}
+	return fmt.Errorf("Security list %q does not contain egress rule %+v", secList.ID, rule)


S should be lowercase

Basic test using modified subset of ServiceTestJig from core's e2e test suite.

Implements a stripped down version of the Service mutability test from the Kubernetes core E2E test suite.

prydie · 2018-02-26T15:01:07Z

@jhorwit2 Yes, sorry I should have given you some more context before asking you to take a look. It's still pretty rough around the edges but what I've done is copy parts of the core E2E test framework and Service tests out that apply to the subset of Service type=LoadBalancer functionality that OCI supports.

jhorwit2 · 2018-02-26T15:41:10Z

@prydie do you plan to add the ESIPP tests?

prydie · 2018-02-26T22:02:33Z

@jhorwit2 yes; I got started on it today but got distracted. I’m hoping that gives us enough coverage LB wise to swith to the new OCI SDK. What I’m less clear on is what to do about instances if you have any ideas?

Although OCI LBaaS is not a pass-through load balancer (and thus does not support ESIPP) this ports the tests covering support for node-local vs cluster-wide routing (i.e. the avoidance of a second hop in the node-local case at the risk of potentially imbalanced traffic spreading.

prydie · 2018-03-01T09:52:39Z

Ran 3 of 3 Specs in 869.765 seconds
SUCCESS! -- 3 Passed | 0 Failed | 0 Pending | 0 Skipped PASS

Ginkgo ran 1 suite in 14m38.555122502s
Test Suite Passed

prydie · 2018-03-01T12:59:07Z

test/e2e/framework/util.go

+	extensionsinternal "k8s.io/kubernetes/pkg/apis/extensions"
+	"k8s.io/kubernetes/pkg/client/clientset_generated/internalclientset"
+	"k8s.io/kubernetes/pkg/controller"
+	"k8s.io/kubernetes/pkg/kubectl"


This adds the dependency on docker and is only used for the reaping of RC and associated pods (via kubectl.Reaper). Might be worth ditching the dependency?

…27-18-43-52 to github (#115) Releasing version V1.8.0

…m fix/oc5-IMDS-lookup to internal * commit 'e02af62049505fef765ec720a5c990e0e78ef33d': Enable IMDS server lookup

prydie force-pushed the ap-lb-integration branch from 0c039a2 to 8841eac Compare February 23, 2018 10:39

prydie commented Feb 23, 2018

View reviewed changes

docs/development.md Outdated

go test -timeout 45m -v ./test/integration/loadbalancer

```

Copy link

Contributor Author

prydie Feb 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defunct

jhorwit2 suggested changes Feb 26, 2018

View reviewed changes

prydie added 2 commits February 26, 2018 13:08

Scaffolding for e2e tests

a7df9d5

Import ServiceTestJig from core e2e tests

51accfe

Basic test using modified subset of ServiceTestJig from core's e2e test suite.

prydie force-pushed the ap-lb-integration branch from dc5c0a4 to a8af622 Compare February 26, 2018 13:11

prydie added 2 commits February 26, 2018 13:11

Initial working Ginkgo E2E test

83aecb8

Port CCM specific core Service mutability e2e test

a8af622

Implements a stripped down version of the Service mutability test from the Kubernetes core E2E test suite.

prydie changed the title ~~WIP: Extend LB integration tests~~ Port Service E2E tests from core Feb 26, 2018

prydie commented Mar 1, 2018

View reviewed changes

prydie force-pushed the ap-lb-integration branch from 26f9891 to d6d7975 Compare March 1, 2018 13:58

Fix ns teardown on SIGTERM and review comments

bf05471

prydie force-pushed the ap-lb-integration branch from d6d7975 to bf05471 Compare March 1, 2018 14:31

prydie mentioned this pull request Mar 2, 2018

Add basic E2E tests of Zones and Instances interfaces #140

Closed

jhorwit2 approved these changes Mar 2, 2018

View reviewed changes

jhorwit2 merged commit bd0c61b into master Mar 2, 2018

prydie deleted the ap-lb-integration branch March 5, 2018 14:05

jbornemann pushed a commit that referenced this pull request Nov 26, 2018

Merge pull request #87 in SDK/oci-go-sdk from merge_to_github2018-06-…

a2ded71

…27-18-43-52 to github (#115) Releasing version V1.8.0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Port Service E2E tests from core #115

Port Service E2E tests from core #115

prydie commented Jan 15, 2018 •

edited

Loading

prydie commented Jan 17, 2018 •

edited

Loading

prydie Feb 23, 2018

jhorwit2 left a comment

jhorwit2 Feb 25, 2018

prydie Feb 26, 2018

jhorwit2 Feb 25, 2018

jhorwit2 Feb 25, 2018

prydie Mar 1, 2018

jhorwit2 Feb 25, 2018

jhorwit2 Feb 25, 2018

jhorwit2 Feb 26, 2018

jhorwit2 Feb 26, 2018

jhorwit2 Feb 26, 2018

prydie Feb 26, 2018 •

edited

Loading

jhorwit2 Feb 26, 2018

prydie Mar 1, 2018

jhorwit2 Feb 26, 2018

prydie commented Feb 26, 2018

jhorwit2 commented Feb 26, 2018

prydie commented Feb 26, 2018

prydie commented Mar 1, 2018

prydie Mar 1, 2018

Port Service E2E tests from core #115

Port Service E2E tests from core #115

Conversation

prydie commented Jan 15, 2018 • edited Loading

prydie commented Jan 17, 2018 • edited Loading

Choose a reason for hiding this comment

jhorwit2 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prydie Feb 26, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prydie commented Feb 26, 2018

jhorwit2 commented Feb 26, 2018

prydie commented Feb 26, 2018

prydie commented Mar 1, 2018

Choose a reason for hiding this comment

prydie commented Jan 15, 2018 •

edited

Loading

prydie commented Jan 17, 2018 •

edited

Loading

prydie Feb 26, 2018 •

edited

Loading