Add basic E2E tests of Zones and Instances interfaces #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basic test using modified subset of ServiceTestJig from core's e2e test suite.
Implements a stripped down version of the Service mutability test from the Kubernetes core E2E test suite.
Although OCI LBaaS is not a pass-through load balancer (and thus does not support ESIPP) this ports the tests covering support for node-local vs cluster-wide routing (i.e. the avoidance of a second hop in the node-local case at the risk of potentially imbalanced traffic spreading.
Add support for testing the cloudprovider.Interface directly and implement tests for the cloudprovider.Zones interface.
Adds a new VCN OCID config parameter (with a fall back to loading from LB subnet1) and filters VNICs by VCN when looking up instances by node name.
jbornemann
pushed a commit
that referenced
this pull request
Nov 26, 2018
Release 3.1.0 on 2018 11 15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: #115 should be reviewed and merged prior to reviewing this PR (for ease).
This PR adds basic "happy path" coverage of the
cloudprovider.Zonesandcloudprovider.Instancesinterfaces.The tests aren't really "end-to-end" as they test via the interfaces, however, I felt keeping them in the same suite was the easiest route. Happy to split out if that would be preferable.
I have tried to maintain some level of provider agnosticism as I'm not clear on the cloud provider working group's testing strategy.
I have also tried to avoid any coupling to the old OCI SDK as once we have sufficient testing in place we will be migrating to the new SDK.