Skip to content

Move auth.compartment to compartment in config #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2018
Merged

Conversation

prydie
Copy link
Contributor

@prydie prydie commented Apr 5, 2018

Depreciates auth.compartment in favour of compartment but maintains backwards compatibility (for now).

Resolves: #170

@prydie prydie requested a review from owainlewis April 5, 2018 14:02
Depreciates "auth.compartment" in favour of "compartment" but maintains
backwards compatibility (for now).
Copy link
Member

@owainlewis owainlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owainlewis owainlewis merged commit eb16afb into master Apr 6, 2018
@owainlewis owainlewis deleted the ap/fix-170 branch April 6, 2018 12:07
@prydie prydie added this to the 0.3.2 milestone Apr 9, 2018
ayushverma14 pushed a commit to ayushverma14/oci-cloud-controller-manager that referenced this pull request Jul 18, 2022
Depreciates "auth.compartment" in favour of "compartment" but maintains
backwards compatibility (for now).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants