Skip to content

Move auth.compartment to compartment in config #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion manifests/cloud-provider-example.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
auth:
region: us-phoenix-1
tenancy: ocid1.tenancy.oc1..aaaaaaaatyn7scrtwtqedvgrxgr2xunzeo6uanvyhzxqblctwkrpisvke4kq
compartment: ocid1.compartment.oc1..aaaaaaaa3um2atybwhder4qttfhgon4j3hcxgmsvnyvx4flfjyewkkwfzwnq
user: ocid1.user.oc1..aaaaaaaai77mql2xerv7cn6wu3nhxang3y4jk56vo5bn5l5lysl34avnui3q
key: |
-----BEGIN RSA PRIVATE KEY-----
Expand All @@ -11,6 +10,9 @@ auth:
key_passphrase: supersecretpassword
fingerprint: 8c:bf:17:7b:5f:e0:7d:13:75:11:d6:39:0d:e2:84:74

# compartment configures Compartment within which the cluster resides.
compartment: ocid1.compartment.oc1..aaaaaaaa3um2atybwhder4qttfhgon4j3hcxgmsvnyvx4flfjyewkkwfzwnq

# vcn configures the Virtual Cloud Network (VCN) within which the cluster resides.
vcn: ocid1.vcn.oc1..aaaaaaaask7mpk4mij3pnm6yvnntte25ffadxiivpokxevfxgtsu6ftkqhrq

Expand Down
10 changes: 6 additions & 4 deletions pkg/oci/ccm.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,8 @@ var _ cloudprovider.Interface = &CloudProvider{}
// NewCloudProvider creates a new oci.CloudProvider.
func NewCloudProvider(config *Config) (cloudprovider.Interface, error) {
c, err := client.New(common.NewRawConfigurationProvider(
config.Auth.TenancyOCID,
config.Auth.UserOCID,
config.Auth.TenancyID,
config.Auth.UserID,
config.Auth.Region,
config.Auth.Fingerprint,
config.Auth.PrivateKey,
Expand All @@ -79,13 +79,13 @@ func NewCloudProvider(config *Config) (cloudprovider.Interface, error) {
return nil, err
}

if config.Auth.CompartmentOCID == "" {
if config.CompartmentID == "" {
glog.Info("Compartment not supplied in config: attempting to infer from instance metadata")
metadata, err := instancemeta.New().Get()
if err != nil {
return nil, err
}
config.Auth.CompartmentOCID = metadata.CompartmentOCID
config.CompartmentID = metadata.CompartmentOCID
}

if config.VCNID == "" {
Expand All @@ -109,6 +109,8 @@ func init() {
if err != nil {
return nil, err
}
cfg.Complete()

if err = cfg.Validate(); err != nil {
return nil, err
}
Expand Down
32 changes: 23 additions & 9 deletions pkg/oci/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,20 +15,23 @@
package oci

import (
"errors"
"io"
"io/ioutil"

"github.com/golang/glog"
"github.com/pkg/errors"
"gopkg.in/yaml.v2"
)

// AuthConfig holds the configuration required for communicating with the OCI
// API.
type AuthConfig struct {
Region string `yaml:"region"`
TenancyOCID string `yaml:"tenancy"`
CompartmentOCID string `yaml:"compartment"`
UserOCID string `yaml:"user"`
Region string `yaml:"region"`
TenancyID string `yaml:"tenancy"`
// CompartmentID is DEPRECIATED and should be set on the top level Config
// struct.
CompartmentID string `yaml:"compartment"`
UserID string `yaml:"user"`
PrivateKey string `yaml:"key"`
Fingerprint string `yaml:"fingerprint"`
PrivateKeyPassphrase string `yaml:"key_passphrase"` // TODO(apryde): the yaml should be keyPassphrase
Expand All @@ -55,11 +58,22 @@ type Config struct {
Auth AuthConfig `yaml:"auth"`
LoadBalancer LoadBalancerConfig `yaml:"loadBalancer"`

// CompartmentID is the OCID of the Compartment within which the cluster
// resides.
CompartmentID string `yaml:"compartment"`
// VCNID is the OCID of the Virtual Cloud Network (VCN) within which the
// cluster resides.
VCNID string `yaml:"vcn"`
}

// Complete the config applying defaults / overrides.
func (c *Config) Complete() {
if c.CompartmentID == "" && c.Auth.CompartmentID != "" {
glog.Warning("cloud-provider config: \"auth.compartment\" is DEPRECIATED and will be removed in a later release. Please set \"compartment\".")
c.CompartmentID = c.Auth.CompartmentID
}
}

// Validate validates the OCI cloud-provider config.
func (c *Config) Validate() error {
return ValidateConfig(c).ToAggregate()
Expand All @@ -71,15 +85,15 @@ func ReadConfig(r io.Reader) (*Config, error) {
return nil, errors.New("no cloud-provider config file given")
}

cfg := &Config{}

b, err := ioutil.ReadAll(r)
if err != nil {
return nil, err
return nil, errors.Wrap(err, "reading cloud-provider config")
}

cfg := &Config{}
err = yaml.Unmarshal(b, &cfg)
if err != nil {
return nil, err
return nil, errors.Wrap(err, "unmarshalling cloud-provider config")
}

return cfg, nil
Expand Down
9 changes: 5 additions & 4 deletions pkg/oci/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ const validConfig = `
auth:
region: us-phoenix-1
tenancy: ocid1.tenancy.oc1..aaaaaaaatyn7scrtwtqedvgrxgr2xunzeo6uanvyhzxqblctwkrpisvke4kq
compartment: ocid1.compartment.oc1..aaaaaaaa3um2atybwhder4qttfhgon4j3hcxgmsvnyvx4flfjyewkkwfzwnq
user: ocid1.user.oc1..aaaaaaaai77mql2xerv7cn6wu3nhxang3y4jk56vo5bn5l5lysl34avnui3q
key: |
-----BEGIN RSA PRIVATE KEY-----
Expand Down Expand Up @@ -62,6 +61,8 @@ auth:
-----END RSA PRIVATE KEY-----
fingerprint: 97:84:f7:26:a3:7b:74:d0:bd:4e:08:a7:79:c9:d0:1d

compartment: ocid1.compartment.oc1..aaaaaaaa3um2atybwhder4qttfhgon4j3hcxgmsvnyvx4flfjyewkkwfzwnq

loadBalancer:
disableSecurityListManagement: false
subnet1: ocid1.subnet.oc1.phx.aaaaaaaasa53hlkzk6nzksqfccegk2qnkxmphkblst3riclzs4rhwg7rg57q
Expand Down Expand Up @@ -132,8 +133,8 @@ func TestReadConfigShouldSetCompartmentOCIDWhenProvidedValidConfig(t *testing.T)
}
expected := "ocid1.compartment.oc1..aaaaaaaa3um2atybwhder4qttfhgon4j3hcxgmsvnyvx4flfjyewkkwfzwnq"

if cfg.Auth.CompartmentOCID != expected {
t.Errorf("Got Auth.CompartmentOCID = %s; want Auth.CompartmentOCID = %s",
cfg.Auth.CompartmentOCID, expected)
if cfg.CompartmentID != expected {
t.Errorf("Got CompartmentID = %s; want CompartmentID = %s",
cfg.CompartmentID, expected)
}
}
4 changes: 2 additions & 2 deletions pkg/oci/config_validate.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ func validateAuthConfig(c *AuthConfig, fldPath *field.Path) field.ErrorList {
if c.Region == "" {
allErrs = append(allErrs, field.Required(fldPath.Child("region"), ""))
}
if c.TenancyOCID == "" {
if c.TenancyID == "" {
allErrs = append(allErrs, field.Required(fldPath.Child("tenancy"), ""))
}
if c.UserOCID == "" {
if c.UserID == "" {
allErrs = append(allErrs, field.Required(fldPath.Child("user"), ""))
}
if c.PrivateKey == "" {
Expand Down
90 changes: 45 additions & 45 deletions pkg/oci/config_validate_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,12 @@ func TestValidateConfig(t *testing.T) {
name: "valid",
in: &Config{
Auth: AuthConfig{
Region: "us-phoenix-1",
TenancyOCID: "ocid1.tenancy.oc1..aaaaaaaatyn7scrtwtqedvgrxgr2xunzeo6uanvyhzxqblctwkrpisvke4kq",
CompartmentOCID: "ocid1.compartment.oc1..aaaaaaaa3um2atybwhder4qttfhgon4j3hcxgmsvnyvx4flfjyewkkwfzwnq",
UserOCID: "ocid1.user.oc1..aaaaaaaai77mql2xerv7cn6wu3nhxang3y4jk56vo5bn5l5lysl34avnui3q",
PrivateKey: "-----BEGIN RSA PRIVATE KEY----- (etc)",
Fingerprint: "8c:bf:17:7b:5f:e0:7d:13:75:11:d6:39:0d:e2:84:74",
Region: "us-phoenix-1",
TenancyID: "ocid1.tenancy.oc1..aaaaaaaatyn7scrtwtqedvgrxgr2xunzeo6uanvyhzxqblctwkrpisvke4kq",
CompartmentID: "ocid1.compartment.oc1..aaaaaaaa3um2atybwhder4qttfhgon4j3hcxgmsvnyvx4flfjyewkkwfzwnq",
UserID: "ocid1.user.oc1..aaaaaaaai77mql2xerv7cn6wu3nhxang3y4jk56vo5bn5l5lysl34avnui3q",
PrivateKey: "-----BEGIN RSA PRIVATE KEY----- (etc)",
Fingerprint: "8c:bf:17:7b:5f:e0:7d:13:75:11:d6:39:0d:e2:84:74",
},
LoadBalancer: LoadBalancerConfig{
Subnet1: "ocid1.tenancy.oc1..aaaaaaaatyn7scrtwtqedvgrxgr2xunzeo6uanvyhzxqblctwkrpisvke4kq",
Expand All @@ -48,11 +48,11 @@ func TestValidateConfig(t *testing.T) {
name: "missing_region",
in: &Config{
Auth: AuthConfig{
TenancyOCID: "ocid1.tenancy.oc1..aaaaaaaatyn7scrtwtqedvgrxgr2xunzeo6uanvyhzxqblctwkrpisvke4kq",
CompartmentOCID: "ocid1.compartment.oc1..aaaaaaaa3um2atybwhder4qttfhgon4j3hcxgmsvnyvx4flfjyewkkwfzwnq",
UserOCID: "ocid1.user.oc1..aaaaaaaai77mql2xerv7cn6wu3nhxang3y4jk56vo5bn5l5lysl34avnui3q",
PrivateKey: "-----BEGIN RSA PRIVATE KEY----- (etc)",
Fingerprint: "8c:bf:17:7b:5f:e0:7d:13:75:11:d6:39:0d:e2:84:74",
TenancyID: "ocid1.tenancy.oc1..aaaaaaaatyn7scrtwtqedvgrxgr2xunzeo6uanvyhzxqblctwkrpisvke4kq",
CompartmentID: "ocid1.compartment.oc1..aaaaaaaa3um2atybwhder4qttfhgon4j3hcxgmsvnyvx4flfjyewkkwfzwnq",
UserID: "ocid1.user.oc1..aaaaaaaai77mql2xerv7cn6wu3nhxang3y4jk56vo5bn5l5lysl34avnui3q",
PrivateKey: "-----BEGIN RSA PRIVATE KEY----- (etc)",
Fingerprint: "8c:bf:17:7b:5f:e0:7d:13:75:11:d6:39:0d:e2:84:74",
},
LoadBalancer: LoadBalancerConfig{
Subnet1: "ocid1.tenancy.oc1..aaaaaaaatyn7scrtwtqedvgrxgr2xunzeo6uanvyhzxqblctwkrpisvke4kq",
Expand All @@ -66,11 +66,11 @@ func TestValidateConfig(t *testing.T) {
name: "missing_tenancy",
in: &Config{
Auth: AuthConfig{
Region: "us-phoenix-1",
CompartmentOCID: "ocid1.compartment.oc1..aaaaaaaa3um2atybwhder4qttfhgon4j3hcxgmsvnyvx4flfjyewkkwfzwnq",
UserOCID: "ocid1.user.oc1..aaaaaaaai77mql2xerv7cn6wu3nhxang3y4jk56vo5bn5l5lysl34avnui3q",
PrivateKey: "-----BEGIN RSA PRIVATE KEY----- (etc)",
Fingerprint: "8c:bf:17:7b:5f:e0:7d:13:75:11:d6:39:0d:e2:84:74",
Region: "us-phoenix-1",
CompartmentID: "ocid1.compartment.oc1..aaaaaaaa3um2atybwhder4qttfhgon4j3hcxgmsvnyvx4flfjyewkkwfzwnq",
UserID: "ocid1.user.oc1..aaaaaaaai77mql2xerv7cn6wu3nhxang3y4jk56vo5bn5l5lysl34avnui3q",
PrivateKey: "-----BEGIN RSA PRIVATE KEY----- (etc)",
Fingerprint: "8c:bf:17:7b:5f:e0:7d:13:75:11:d6:39:0d:e2:84:74",
},
LoadBalancer: LoadBalancerConfig{
Subnet1: "ocid1.tenancy.oc1..aaaaaaaatyn7scrtwtqedvgrxgr2xunzeo6uanvyhzxqblctwkrpisvke4kq",
Expand All @@ -85,8 +85,8 @@ func TestValidateConfig(t *testing.T) {
in: &Config{
Auth: AuthConfig{
Region: "us-phoenix-1",
TenancyOCID: "ocid1.tenancy.oc1..aaaaaaaatyn7scrtwtqedvgrxgr2xunzeo6uanvyhzxqblctwkrpisvke4kq",
UserOCID: "ocid1.user.oc1..aaaaaaaai77mql2xerv7cn6wu3nhxang3y4jk56vo5bn5l5lysl34avnui3q",
TenancyID: "ocid1.tenancy.oc1..aaaaaaaatyn7scrtwtqedvgrxgr2xunzeo6uanvyhzxqblctwkrpisvke4kq",
UserID: "ocid1.user.oc1..aaaaaaaai77mql2xerv7cn6wu3nhxang3y4jk56vo5bn5l5lysl34avnui3q",
PrivateKey: "-----BEGIN RSA PRIVATE KEY----- (etc)",
Fingerprint: "8c:bf:17:7b:5f:e0:7d:13:75:11:d6:39:0d:e2:84:74",
},
Expand All @@ -100,11 +100,11 @@ func TestValidateConfig(t *testing.T) {
name: "missing_user",
in: &Config{
Auth: AuthConfig{
Region: "us-phoenix-1",
TenancyOCID: "ocid1.tenancy.oc1..aaaaaaaatyn7scrtwtqedvgrxgr2xunzeo6uanvyhzxqblctwkrpisvke4kq",
CompartmentOCID: "ocid1.compartment.oc1..aaaaaaaa3um2atybwhder4qttfhgon4j3hcxgmsvnyvx4flfjyewkkwfzwnq",
PrivateKey: "-----BEGIN RSA PRIVATE KEY----- (etc)",
Fingerprint: "8c:bf:17:7b:5f:e0:7d:13:75:11:d6:39:0d:e2:84:74",
Region: "us-phoenix-1",
TenancyID: "ocid1.tenancy.oc1..aaaaaaaatyn7scrtwtqedvgrxgr2xunzeo6uanvyhzxqblctwkrpisvke4kq",
CompartmentID: "ocid1.compartment.oc1..aaaaaaaa3um2atybwhder4qttfhgon4j3hcxgmsvnyvx4flfjyewkkwfzwnq",
PrivateKey: "-----BEGIN RSA PRIVATE KEY----- (etc)",
Fingerprint: "8c:bf:17:7b:5f:e0:7d:13:75:11:d6:39:0d:e2:84:74",
},
LoadBalancer: LoadBalancerConfig{
Subnet1: "ocid1.tenancy.oc1..aaaaaaaatyn7scrtwtqedvgrxgr2xunzeo6uanvyhzxqblctwkrpisvke4kq",
Expand All @@ -118,11 +118,11 @@ func TestValidateConfig(t *testing.T) {
name: "missing_key",
in: &Config{
Auth: AuthConfig{
Region: "us-phoenix-1",
TenancyOCID: "ocid1.tenancy.oc1..aaaaaaaatyn7scrtwtqedvgrxgr2xunzeo6uanvyhzxqblctwkrpisvke4kq",
CompartmentOCID: "ocid1.compartment.oc1..aaaaaaaa3um2atybwhder4qttfhgon4j3hcxgmsvnyvx4flfjyewkkwfzwnq",
UserOCID: "ocid1.user.oc1..aaaaaaaai77mql2xerv7cn6wu3nhxang3y4jk56vo5bn5l5lysl34avnui3q",
Fingerprint: "8c:bf:17:7b:5f:e0:7d:13:75:11:d6:39:0d:e2:84:74",
Region: "us-phoenix-1",
TenancyID: "ocid1.tenancy.oc1..aaaaaaaatyn7scrtwtqedvgrxgr2xunzeo6uanvyhzxqblctwkrpisvke4kq",
CompartmentID: "ocid1.compartment.oc1..aaaaaaaa3um2atybwhder4qttfhgon4j3hcxgmsvnyvx4flfjyewkkwfzwnq",
UserID: "ocid1.user.oc1..aaaaaaaai77mql2xerv7cn6wu3nhxang3y4jk56vo5bn5l5lysl34avnui3q",
Fingerprint: "8c:bf:17:7b:5f:e0:7d:13:75:11:d6:39:0d:e2:84:74",
},
LoadBalancer: LoadBalancerConfig{
Subnet1: "ocid1.tenancy.oc1..aaaaaaaatyn7scrtwtqedvgrxgr2xunzeo6uanvyhzxqblctwkrpisvke4kq",
Expand All @@ -136,11 +136,11 @@ func TestValidateConfig(t *testing.T) {
name: "missing_figerprint",
in: &Config{
Auth: AuthConfig{
Region: "us-phoenix-1",
TenancyOCID: "ocid1.tenancy.oc1..aaaaaaaatyn7scrtwtqedvgrxgr2xunzeo6uanvyhzxqblctwkrpisvke4kq",
CompartmentOCID: "ocid1.compartment.oc1..aaaaaaaa3um2atybwhder4qttfhgon4j3hcxgmsvnyvx4flfjyewkkwfzwnq",
UserOCID: "ocid1.user.oc1..aaaaaaaai77mql2xerv7cn6wu3nhxang3y4jk56vo5bn5l5lysl34avnui3q",
PrivateKey: "-----BEGIN RSA PRIVATE KEY----- (etc)",
Region: "us-phoenix-1",
TenancyID: "ocid1.tenancy.oc1..aaaaaaaatyn7scrtwtqedvgrxgr2xunzeo6uanvyhzxqblctwkrpisvke4kq",
CompartmentID: "ocid1.compartment.oc1..aaaaaaaa3um2atybwhder4qttfhgon4j3hcxgmsvnyvx4flfjyewkkwfzwnq",
UserID: "ocid1.user.oc1..aaaaaaaai77mql2xerv7cn6wu3nhxang3y4jk56vo5bn5l5lysl34avnui3q",
PrivateKey: "-----BEGIN RSA PRIVATE KEY----- (etc)",
},
LoadBalancer: LoadBalancerConfig{
Subnet1: "ocid1.tenancy.oc1..aaaaaaaatyn7scrtwtqedvgrxgr2xunzeo6uanvyhzxqblctwkrpisvke4kq",
Expand All @@ -154,12 +154,12 @@ func TestValidateConfig(t *testing.T) {
name: "missing_subnet1",
in: &Config{
Auth: AuthConfig{
Region: "us-phoenix-1",
TenancyOCID: "ocid1.tenancy.oc1..aaaaaaaatyn7scrtwtqedvgrxgr2xunzeo6uanvyhzxqblctwkrpisvke4kq",
CompartmentOCID: "ocid1.compartment.oc1..aaaaaaaa3um2atybwhder4qttfhgon4j3hcxgmsvnyvx4flfjyewkkwfzwnq",
UserOCID: "ocid1.user.oc1..aaaaaaaai77mql2xerv7cn6wu3nhxang3y4jk56vo5bn5l5lysl34avnui3q",
PrivateKey: "-----BEGIN RSA PRIVATE KEY----- (etc)",
Fingerprint: "8c:bf:17:7b:5f:e0:7d:13:75:11:d6:39:0d:e2:84:74",
Region: "us-phoenix-1",
TenancyID: "ocid1.tenancy.oc1..aaaaaaaatyn7scrtwtqedvgrxgr2xunzeo6uanvyhzxqblctwkrpisvke4kq",
CompartmentID: "ocid1.compartment.oc1..aaaaaaaa3um2atybwhder4qttfhgon4j3hcxgmsvnyvx4flfjyewkkwfzwnq",
UserID: "ocid1.user.oc1..aaaaaaaai77mql2xerv7cn6wu3nhxang3y4jk56vo5bn5l5lysl34avnui3q",
PrivateKey: "-----BEGIN RSA PRIVATE KEY----- (etc)",
Fingerprint: "8c:bf:17:7b:5f:e0:7d:13:75:11:d6:39:0d:e2:84:74",
},
LoadBalancer: LoadBalancerConfig{
Subnet2: "ocid1.subnet.oc1.phx.aaaaaaaahuxrgvs65iwdz7ekwgg3l5gyah7ww5klkwjcso74u3e4i64hvtvq",
Expand All @@ -172,12 +172,12 @@ func TestValidateConfig(t *testing.T) {
name: "missing_subnet2",
in: &Config{
Auth: AuthConfig{
Region: "us-phoenix-1",
TenancyOCID: "ocid1.tenancy.oc1..aaaaaaaatyn7scrtwtqedvgrxgr2xunzeo6uanvyhzxqblctwkrpisvke4kq",
CompartmentOCID: "ocid1.compartment.oc1..aaaaaaaa3um2atybwhder4qttfhgon4j3hcxgmsvnyvx4flfjyewkkwfzwnq",
UserOCID: "ocid1.user.oc1..aaaaaaaai77mql2xerv7cn6wu3nhxang3y4jk56vo5bn5l5lysl34avnui3q",
PrivateKey: "-----BEGIN RSA PRIVATE KEY----- (etc)",
Fingerprint: "8c:bf:17:7b:5f:e0:7d:13:75:11:d6:39:0d:e2:84:74",
Region: "us-phoenix-1",
TenancyID: "ocid1.tenancy.oc1..aaaaaaaatyn7scrtwtqedvgrxgr2xunzeo6uanvyhzxqblctwkrpisvke4kq",
CompartmentID: "ocid1.compartment.oc1..aaaaaaaa3um2atybwhder4qttfhgon4j3hcxgmsvnyvx4flfjyewkkwfzwnq",
UserID: "ocid1.user.oc1..aaaaaaaai77mql2xerv7cn6wu3nhxang3y4jk56vo5bn5l5lysl34avnui3q",
PrivateKey: "-----BEGIN RSA PRIVATE KEY----- (etc)",
Fingerprint: "8c:bf:17:7b:5f:e0:7d:13:75:11:d6:39:0d:e2:84:74",
},
LoadBalancer: LoadBalancerConfig{
Subnet1: "ocid1.tenancy.oc1..aaaaaaaatyn7scrtwtqedvgrxgr2xunzeo6uanvyhzxqblctwkrpisvke4kq",
Expand Down
12 changes: 6 additions & 6 deletions pkg/oci/instances.go
Original file line number Diff line number Diff line change
Expand Up @@ -78,12 +78,12 @@ func extractNodeAddressesFromVNIC(vnic *core.Vnic) ([]api.NodeAddress, error) {
func (cp *CloudProvider) NodeAddresses(ctx context.Context, name types.NodeName) ([]api.NodeAddress, error) {
glog.V(4).Infof("NodeAddresses(%q) called", name)

inst, err := cp.client.Compute().GetInstanceByNodeName(ctx, cp.config.Auth.CompartmentOCID, cp.config.VCNID, mapNodeNameToInstanceName(name))
inst, err := cp.client.Compute().GetInstanceByNodeName(ctx, cp.config.CompartmentID, cp.config.VCNID, mapNodeNameToInstanceName(name))
if err != nil {
return nil, errors.Wrap(err, "GetInstanceByNodeName")
}

vnic, err := cp.client.Compute().GetPrimaryVNICForInstance(ctx, cp.config.Auth.CompartmentOCID, *inst.Id)
vnic, err := cp.client.Compute().GetPrimaryVNICForInstance(ctx, cp.config.CompartmentID, *inst.Id)
if err != nil {
return nil, errors.Wrap(err, "GetPrimaryVNICForInstance")
}
Expand All @@ -98,7 +98,7 @@ func (cp *CloudProvider) NodeAddresses(ctx context.Context, name types.NodeName)
func (cp *CloudProvider) NodeAddressesByProviderID(ctx context.Context, providerID string) ([]api.NodeAddress, error) {
glog.V(4).Infof("NodeAddressesByProviderID(%q) called", providerID)
instanceID := util.MapProviderIDToInstanceID(providerID)
vnic, err := cp.client.Compute().GetPrimaryVNICForInstance(ctx, cp.config.Auth.CompartmentOCID, instanceID)
vnic, err := cp.client.Compute().GetPrimaryVNICForInstance(ctx, cp.config.CompartmentID, instanceID)
if err != nil {
return nil, errors.Wrap(err, "GetPrimaryVNICForInstance")
}
Expand All @@ -112,7 +112,7 @@ func (cp *CloudProvider) ExternalID(ctx context.Context, nodeName types.NodeName
glog.V(4).Infof("ExternalID(%q) called", nodeName)

instName := mapNodeNameToInstanceName(nodeName)
inst, err := cp.client.Compute().GetInstanceByNodeName(ctx, cp.config.Auth.CompartmentOCID, cp.config.VCNID, instName)
inst, err := cp.client.Compute().GetInstanceByNodeName(ctx, cp.config.CompartmentID, cp.config.VCNID, instName)
if client.IsNotFound(err) {
glog.Infof("Instance %q was not found. Unable to get ExternalID: %v", instName, err)
return "", cloudprovider.InstanceNotFound
Expand All @@ -131,7 +131,7 @@ func (cp *CloudProvider) InstanceID(ctx context.Context, nodeName types.NodeName
glog.V(4).Infof("InstanceID(%q) called", nodeName)

name := mapNodeNameToInstanceName(nodeName)
inst, err := cp.client.Compute().GetInstanceByNodeName(ctx, cp.config.Auth.CompartmentOCID, cp.config.VCNID, name)
inst, err := cp.client.Compute().GetInstanceByNodeName(ctx, cp.config.CompartmentID, cp.config.VCNID, name)
if err != nil {
if client.IsNotFound(err) {
return "", cloudprovider.InstanceNotFound
Expand All @@ -145,7 +145,7 @@ func (cp *CloudProvider) InstanceID(ctx context.Context, nodeName types.NodeName
func (cp *CloudProvider) InstanceType(ctx context.Context, name types.NodeName) (string, error) {
glog.V(4).Infof("InstanceType(%q) called", name)

inst, err := cp.client.Compute().GetInstanceByNodeName(ctx, cp.config.Auth.CompartmentOCID, cp.config.VCNID, mapNodeNameToInstanceName(name))
inst, err := cp.client.Compute().GetInstanceByNodeName(ctx, cp.config.CompartmentID, cp.config.VCNID, mapNodeNameToInstanceName(name))
if err != nil {
return "", errors.Wrap(err, "GetInstanceByNodeName")
}
Expand Down
Loading