Support configuration of security list management modes as LB service annotation #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 1, 2018 13:42
prydie
suggested changes
Aug 2, 2018
| @@ -130,24 +129,22 @@ func (cp *CloudProvider) Initialize(clientBuilder controller.ControllerClientBui | |||
|
|
|||
| nodeInformer := factory.Core().V1().Nodes() | |||
| go nodeInformer.Informer().Run(wait.NeverStop) | |||
| serviceInformer := factory.Core().V1().Services() | |||
| go serviceInformer.Informer().Run(wait.NeverStop) | |||
There was a problem hiding this comment.
Might want to stick a \n under here to separate out the setup vs the cache sync
pkg/oci/load_balancer.go
Outdated
| // have SSL enabled. | ||
| // See: https://kubernetes.io/docs/concepts/services-networking/ingress/#tls | ||
| ServiceAnnotationLoadBalancerTLSSecret = "service.beta.kubernetes.io/oci-load-balancer-tls-secret" | ||
|
|
||
| // ServiceAnnotationLoadBalancerConnectionIdleTimeout is the annotation used | ||
| // on the service to specify the idle connection timeout. | ||
| ServiceAnnotationLoadBalancerConnectionIdleTimeout = "service.beta.kubernetes.io/oci-load-balancer-connection-idle-timeout" | ||
|
|
||
| //ServiceAnnotaionLoadBalancerSecurityListManagementMode is a Service annotation for |
pkg/oci/load_balancer.go
Outdated
| // have SSL enabled. | ||
| // See: https://kubernetes.io/docs/concepts/services-networking/ingress/#tls | ||
| ServiceAnnotationLoadBalancerTLSSecret = "service.beta.kubernetes.io/oci-load-balancer-tls-secret" | ||
|
|
||
| // ServiceAnnotationLoadBalancerConnectionIdleTimeout is the annotation used | ||
| // on the service to specify the idle connection timeout. | ||
| ServiceAnnotationLoadBalancerConnectionIdleTimeout = "service.beta.kubernetes.io/oci-load-balancer-connection-idle-timeout" | ||
|
|
||
| //ServiceAnnotaionLoadBalancerSecurityListManagementMode is a Service annotation for | ||
| //specifying the security list managment mode ("All","Frontend","None") that configures how security lists are managed by the CCM |
There was a problem hiding this comment.
Space after // and ("All", "Frontend", "None")
pkg/oci/load_balancer_spec.go
Outdated
| Ports map[string]portSpec | ||
| SourceCIDRs []string | ||
| SSLConfig *SSLConfig | ||
| SecurityListManager securityListManager |
There was a problem hiding this comment.
I wouldn't export this field so securityListManager
pkg/oci/load_balancer_spec.go
Outdated
| @@ -134,6 +135,10 @@ func NewLBSpec(svc *v1.Service, nodes []*v1.Node, defaultSubnets []string, sslCf | |||
| return nil, err | |||
| } | |||
|
|
|||
| //A security list manager will be configured based on the annotation specified when creating the service, | |||
pkg/oci/load_balancer_spec.go
Outdated
| @@ -134,6 +135,10 @@ func NewLBSpec(svc *v1.Service, nodes []*v1.Node, defaultSubnets []string, sslCf | |||
| return nil, err | |||
| } | |||
|
|
|||
| //A security list manager will be configured based on the annotation specified when creating the service, | |||
| //if an annotation is not specified, then the mode specified in cloud provider config file is used. | |||
pkg/oci/load_balancer_spec.go
Outdated
| nodes: nodes, | ||
| service: svc, | ||
| nodes: nodes, | ||
| SecurityListManager: slManagerSpec, |
There was a problem hiding this comment.
SecurityListManager: secListFactory(
svc.Annotations[ServiceAnnotaionLoadBalancerSecurityListManagementMode],
)
pkg/oci/load_balancer_spec_test.go
Outdated
| @@ -312,7 +318,11 @@ func TestNewLBSpecSuccess(t *testing.T) { | |||
| // we expect the service to be unchanged | |||
| tc.expected.service = tc.service | |||
| subnets := []string{tc.defaultSubnetOne, tc.defaultSubnetTwo} | |||
| result, err := NewLBSpec(tc.service, tc.nodes, subnets, nil) | |||
| //reference default cp added | |||
| @@ -330,7 +340,8 @@ func TestNewLBSpecFailure(t *testing.T) { | |||
| defaultSubnetTwo string | |||
| nodes []*v1.Node | |||
| service *v1.Service | |||
| expectedErrMsg string | |||
| //add cp or cp security list | |||
| @@ -415,6 +426,7 @@ func TestNewLBSpecFailure(t *testing.T) { | |||
| Spec: v1.ServiceSpec{ | |||
| SessionAffinity: v1.ServiceAffinityNone, | |||
| Ports: []v1.ServicePort{}, | |||
| //add security list mananger in spec | |||
|
The seg fault issue is already fixed in master. |
prydie
approved these changes
Aug 2, 2018
|
Awesome work @bdourallawzi 👍 |
ayushverma14
pushed a commit
to ayushverma14/oci-cloud-controller-manager
that referenced
this pull request
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For customers running in a management environment, they will not be able to modify the configuration of the CCM.This allows for dynamic configuration of security list management mode (All, Frontend, None) by adding an annotation when creating a LB service.
This covers the following enhancement #217 as well as covering the seg fault issue #221