Bl/adding seclistmode documentation #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prydie
suggested changes
Aug 3, 2018
docs/load-balancer-annotations.md
Outdated
| @@ -27,6 +27,7 @@ spec: | |||
| | `oci-load-balancer-subnet1` | The OCID of the first [subnet][2] of the two required subnets to attach the load balancer to. Must be in separate Availability Domains. | Value provided in config file | | |||
| | `oci-load-balancer-subnet2` | The OCID of the second [subnet][2] of the two required subnets to attach the load balancer to. Must be in separate Availability Domains. | Value provided in config file | | |||
| | `oci-load-balancer-connection-idle-timeout` | The maximum idle time, in seconds, allowed between two successive receive or two successive send operations between the client and backend servers. | `300` for TCP listeners, `60` for HTTP listeners | | |||
| | `oci-load-balancer-security-list-management-mode` | Specifies the security list mode ("All", "Frontend", "None") to configure how security lists are managed by the CCM | `"All"` | |||
| ports: | ||
| - name: http | ||
| port: 80 | ||
| targetPort: 80 |
There was a problem hiding this comment.
nit: trailing newline
(you probably need to configure "files.insertFinalNewline": true" in vscode)
| @@ -0,0 +1,93 @@ | |||
| # Tutorial | |||
There was a problem hiding this comment.
I'm not sure we need a tutorial specifically for the annotation, however, the possible annotation options and their effects certainly need to be documented front and centre.
bdourallawzi
commented
Aug 3, 2018
| @@ -27,6 +27,7 @@ spec: | |||
| | `oci-load-balancer-subnet1` | The OCID of the first [subnet][2] of the two required subnets to attach the load balancer to. Must be in separate Availability Domains. | Value provided in config file | | |||
| | `oci-load-balancer-subnet2` | The OCID of the second [subnet][2] of the two required subnets to attach the load balancer to. Must be in separate Availability Domains. | Value provided in config file | | |||
| | `oci-load-balancer-connection-idle-timeout` | The maximum idle time, in seconds, allowed between two successive receive or two successive send operations between the client and backend servers. | `300` for TCP listeners, `60` for HTTP listeners | | |||
| | `oci-load-balancer-security-list-management-mode` | Specifies the [security list mode](##security-list-management-modes) (`"All"`, `"Frontend"`,`"None"`) to configure how security lists are managed by the CCM. | `"All"` | |||
There was a problem hiding this comment.
I modified the markdown format. I am trying to link the security list management mode to the heading below but doesn't seem to work. :( Might be just GitHub.
prydie
approved these changes
Aug 7, 2018
ayushverma14
pushed a commit
to ayushverma14/oci-cloud-controller-manager
that referenced
this pull request
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified documentation to the load balancer annotation doc on configuring the security list management mode.
Added a tutorial and example.
Covers documentation for the following commit: #225