Option to disable logging of log producer (2nd try) #1400
Conversation
… < 9. [Issue #1069 - Marc Stern]
CHANGES
Outdated
| @@ -1,6 +1,9 @@ | |||
| DD MMM YYYY - 2.9.2 - To be released | |||
| ------------------------------------ | |||
|
|
|||
| * {dis|en}able-dechunk-logging: Option to disable logging of | |||
| dechunking in audit log when log level < 9. | |||
| [Issue #1068 - Marc Stern] | |||
There was a problem hiding this comment.
Issue number is not correct.
CHANGES
Outdated
| @@ -1,6 +1,9 @@ | |||
| DD MMM YYYY - 2.9.2 - To be released | |||
| ------------------------------------ | |||
|
|
|||
| * {dis|en}able-dechunk-logging: Option to disable logging of | |||
There was a problem hiding this comment.
This one is about the producer, not the dechunking :P
apache2/msc_logging.c
Outdated
| @@ -1174,6 +1174,9 @@ void sec_audit_logger_json(modsec_rec *msr) { | |||
| yajl_kv_bool(g, "response_body_dechunked", 1); | |||
| } | |||
|
|
|||
| #ifdef LOG_NO_PRODUCER | |||
There was a problem hiding this comment.
This is not more than the single producer entry ?
apache2/msc_logging.c
Outdated
| @@ -1323,6 +1326,9 @@ void sec_audit_logger_json(modsec_rec *msr) { | |||
| } | |||
| } | |||
|
|
|||
| #ifdef LOG_NO_PRODUCER | |||
| } | |||
| #endif | |||
There was a problem hiding this comment.
Hey wait. This is only about JSON version?
Added conditional logging of multi-line logging on top of JSON Didn't include "Web application info" in the conditional logging
|
Fixed |
apache2/msc_logging.c
Outdated
| @@ -1271,6 +1271,9 @@ void sec_audit_logger_json(modsec_rec *msr) { | |||
| if (been_opened == 1) { | |||
| yajl_gen_map_close(g); // sanitized args map is finished | |||
| } | |||
| #ifdef LOG_NO_PRODUCER | |||
There was a problem hiding this comment.
This is way more than the simple producer tag.
apache2/msc_logging.c
Outdated
| @@ -2013,6 +2013,9 @@ void sec_audit_logger_native(modsec_rec *msr) { | |||
| sec_auditlog_write(msr, text, strlen(text)); | |||
| } | |||
|
|
|||
| #ifdef LOG_NO_PRODUCER | |||
There was a problem hiding this comment.
Same as above - too many things ignored that are not the producer.
|
The goal was to remove all the "contextual" environment, which is indeed more than the producer. Would it be OK with an explicit name (also in configure) like "LOG_NO_SERVER_CONTEXT"? |
|
If that is the goal, it should be clear to whom may read the code and to the user who may enabling it during the configure. So we have to change the help message and the if/defs. |
…ver info (log producer, sanitized objects, ...) in audit log. [Issue #1069 - Marc Stern]
|
Done: {dis|en}able-server-context-logging |
[Issue #1069 - Marc Stern]