Skip to content

Option to disable logging of log producer (2nd try) #1400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Option to disable logging of log producer (2nd try) #1400

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f586924
Option to disable logging of log producer in audit log when log level…
Apr 27, 2017
6139df8
Fixed CHANGES (PR# and text)
May 3, 2017
a5c3548
{dis|en}able-server-context-logging: Option to disable logging of ser…
May 5, 2017
cfacb87
Merge branch 'master' into v2/log/producer-try2
May 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions CHANGES
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
DD MMM YYYY - 2.9.2 - To be released
------------------------------------

* {dis|en}able-dechunk-logging: Option to disable logging of
dechunking in audit log when log level < 9.
[Issue #1068 - Marc Stern]
* {dis|en}able-log-producer-logging: Option to disable logging of
log producer in audit log.
[Issue #1069 - Marc Stern]
* {dis|en}able-handler-logging: Option to disable logging of Apache handler
in audit log
[Issue #1070, #1381 - Marc Stern]
Expand Down
14 changes: 10 additions & 4 deletions apache2/msc_logging.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1271,6 +1271,9 @@ void sec_audit_logger_json(modsec_rec *msr) {
if (been_opened == 1) {
yajl_gen_map_close(g); // sanitized args map is finished
}
#ifdef LOG_NO_PRODUCER
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is way more than the simple producer tag.

}
#endif

/* Web application info. */
if ( ((msr->txcfg->webappid != NULL)&&(strcmp(msr->txcfg->webappid, "default") != 0))
Expand Down Expand Up @@ -1326,9 +1329,6 @@ void sec_audit_logger_json(modsec_rec *msr) {
}
}

#ifdef LOG_NO_PRODUCER
}
#endif
yajl_gen_map_close(g); // audit_data top-level key is finished

/* AUDITLOG_PART_UPLOADS */
Expand Down Expand Up @@ -2013,6 +2013,9 @@ void sec_audit_logger_native(modsec_rec *msr) {
sec_auditlog_write(msr, text, strlen(text));
}

#ifdef LOG_NO_PRODUCER
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above - too many things ignored that are not the producer.

if (msr->txcfg->debuglog_level >= 9) {
#endif
sec_auditlog_write_producer_header(msr);

/* Server */
Expand Down Expand Up @@ -2082,7 +2085,10 @@ void sec_audit_logger_native(modsec_rec *msr) {
}
}

/* Web application info. */
#ifdef LOG_NO_PRODUCER
}
#endif
/* Web application info. */
if ( ((msr->txcfg->webappid != NULL)&&(strcmp(msr->txcfg->webappid, "default") != 0))
|| (msr->sessionid != NULL) || (msr->userid != NULL))
{
Expand Down