DOC: Simplify pandas theme footer #52149
Conversation
natmokval
changed the title
There was a problem hiding this comment.
Thanks for working on this @natmokval, added some comments that I think should help.
| @@ -36,17 +36,6 @@ table { | |||
| padding: 2.5rem 0rem 0.5rem 0rem; | |||
| } | |||
|
|
|||
| .intro-card .card-footer { | |||
There was a problem hiding this comment.
I don't think we should modify the css for this. Am I missing something? I think you probably want to revert this deletion.
| @@ -240,7 +240,7 @@ | |||
|
|
|||
| html_theme_options = { | |||
| "external_links": [], | |||
| "footer_items": ["pandas_footer", "sphinx-version"], | |||
| "footer_start": ["pandas_footer", "sphinx-version"], | |||
| "github_url": "https://github.com/pandas-dev/pandas", | |||
| "twitter_url": "https://twitter.com/pandas_dev", | |||
| "google_analytics_id": "UA-27880019-2", | |||
There was a problem hiding this comment.
For the error in the CI seems like this config has veen removed: WARNING: unsupported theme option 'google_analytics_id' given
Can you check on the pydata theme docs which is the new way to do this please?
| @@ -87,7 +87,7 @@ dependencies: | |||
| - gitdb | |||
| - natsort # DataFrame.sort_values doctest | |||
| - numpydoc | |||
| - pydata-sphinx-theme<0.11 | |||
| - pydata-sphinx-theme>=0.13.0 | |||
There was a problem hiding this comment.
I think it's better to simply remove the version here, it should pick the last one anyway.
| @@ -62,7 +62,7 @@ gitpython | |||
| gitdb | |||
| natsort | |||
| numpydoc | |||
| pydata-sphinx-theme<0.11 | |||
| pydata-sphinx-theme>=0.13.0 | |||
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
@natmokval do you still want to work on this? |
|
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. |
This pr is related to issue #51536. The next changes were made:
pydata-sphinx-themein environment.yml from less than 0.11 to 0.13.0html_theme_options. Now "footer_start" is used instead of "footer_items”pydata-sphinx-themeI removedcard-footer