Skip to content

DOC: Simplify pandas theme footer #52149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

DOC: Simplify pandas theme footer #52149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions doc/source/_static/css/pandas.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,17 +36,6 @@ table {
padding: 2.5rem 0rem 0.5rem 0rem;
}

.intro-card .card-footer {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should modify the css for this. Am I missing something? I think you probably want to revert this deletion.

border: none;
background-color: transparent;
}

.intro-card .card-footer p.card-text{
max-width: 220px;
margin-left: auto;
margin-right: auto;
}

.card, .card img {
background-color: transparent !important;
}
2 changes: 1 addition & 1 deletion doc/source/conf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@

html_theme_options = {
"external_links": [],
"footer_items": ["pandas_footer", "sphinx-version"],
"footer_start": ["pandas_footer", "sphinx-version"],
"github_url": "https://github.com/pandas-dev/pandas",
"twitter_url": "https://twitter.com/pandas_dev",
"google_analytics_id": "UA-27880019-2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the error in the CI seems like this config has veen removed: WARNING: unsupported theme option 'google_analytics_id' given

Can you check on the pydata theme docs which is the new way to do this please?

Expand Down
2 changes: 1 addition & 1 deletion environment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ dependencies:
- gitdb
- natsort # DataFrame.sort_values doctest
- numpydoc
- pydata-sphinx-theme<0.11
- pydata-sphinx-theme>=0.13.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to simply remove the version here, it should pick the last one anyway.

- pytest-cython # doctest
- sphinx
- sphinx-panels
Expand Down
2 changes: 1 addition & 1 deletion requirements-dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ gitpython
gitdb
natsort
numpydoc
pydata-sphinx-theme<0.11
pydata-sphinx-theme>=0.13.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

pytest-cython
sphinx
sphinx-panels
Expand Down