PERF: Add short circuiting to RangeIndex._shallow_copy #57534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Performance
phofl
reviewed
Feb 20, 2024
pandas/core/indexes/range.py
Outdated
| diff = values[1] - values[0] | ||
| if diff == 0: | ||
| return False | ||
| curr = values[1] |
There was a problem hiding this comment.
This is still pretty slow I think, I think what you are looking for is is_range_indexer that we built for CoW with a stepsize argument added
There was a problem hiding this comment.
Ah gotcha. I refactored to use is_range_indexer
There was a problem hiding this comment.
Just to be clear, that will only work with stepsize 1 for now, I am open to support other step sizes as well if you like (follow up should be fine)
There was a problem hiding this comment.
Right I "normalize" the values by the stepsize (values - values[0] / values[1] - values[0]) so that is_range_indexer can always be used here
phofl
approved these changes
Feb 20, 2024
|
thx |
This was referenced Feb 20, 2024
|
Still a 10% slowdown compared to before, could you check if we can close the gap further? |
12 tasks
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #57445 (comment)
There needs to be More Work done to attempt to return a RangeIndex, but this should help minimize that Work