-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
PERF: Add short circuiting to RangeIndex._shallow_copy #57534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
dddae1b
PERF: Add short circuiting to RangeIndex._shallow_copy
mroeschke ed4b05d
Merge remote-tracking branch 'upstream/main' into perf/ri/take
mroeschke a83c1fd
Fix bug
mroeschke de9aafb
Avoid set all together
mroeschke a96af34
Remove redundant assignment
mroeschke 54ebbef
Merge remote-tracking branch 'upstream/main' into perf/ri/take
mroeschke 35c9ebd
Use is_range_indexer
mroeschke 18146d5
Remove helper
mroeschke 3315018
Add back test
mroeschke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still pretty slow I think, I think what you are looking for is
is_range_indexer
that we built for CoW with a stepsize argument addedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah gotcha. I refactored to use
is_range_indexer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to be clear, that will only work with stepsize 1 for now, I am open to support other step sizes as well if you like (follow up should be fine)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right I "normalize" the values by the stepsize (
values - values[0] / values[1] - values[0]
) so thatis_range_indexer
can always be used hereThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sorry, yeah that makes sense