-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: Fix #59429 stacked bar label position #60211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Fix #59429 stacked bar label position #60211
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
@@ -774,6 +774,15 @@ def test_bar_nan_stacked(self): | |||
expected = [0.0, 0.0, 0.0, 10.0, 0.0, 20.0, 15.0, 10.0, 40.0] | |||
assert result == expected | |||
|
|||
def test_bar_stacked_label_position_with_zero_height(self): | |||
df = DataFrame({"A": [3, 0, 1], "B": [0, 2, 4], "C": [5, 0, 2]}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you start this test with a comment referencing the GH issue. E.g. see the test immediately below for an example.
doc/source/whatsnew/v2.3.0.rst
Outdated
@@ -143,7 +143,7 @@ Period | |||
|
|||
Plotting | |||
^^^^^^^^ | |||
- | |||
- Bug in :meth:`DataFrame.plot.bar` with ``stacked=True`` where labels on stacked bars with zero-height segments were incorrectly positioned at the base instead of the label position of the previous segment (:issue:`59429`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This note should be move to v3.0.0.rst.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2.3.0 is a "special" release in that we are not doing it from the main branch. We are only backporting certain PRs to the 2.3.x branch.
…tacked-bar-label-position
…d issue tracking number to test as requested
Thank you! I made the requested changes and synced the branch. This is ready for re-review after the checks complete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks @tev-dixon! |
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.