-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: Fix #59429 stacked bar label position #60211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rhshadrach
merged 4 commits into
pandas-dev:main
from
tev-dixon:fix-gh59429-stacked-bar-label-position
Nov 7, 2024
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
44705a8
BUG: Fix label positioning in stacked bar plots with zero-height bars…
e1602fd
Fix pre-commits, add whatsnew documentation
tev-dixon 9c928ee
Merge branch 'main' of github.com:tev-dixon/pandas into fix-gh59429-s…
tev-dixon 352c1a4
Moved whatsnew documentation from v2.3.0 to v3.0.0 as requested, adde…
tev-dixon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -774,6 +774,15 @@ def test_bar_nan_stacked(self): | |
expected = [0.0, 0.0, 0.0, 10.0, 0.0, 20.0, 15.0, 10.0, 40.0] | ||
assert result == expected | ||
|
||
def test_bar_stacked_label_position_with_zero_height(self): | ||
df = DataFrame({"A": [3, 0, 1], "B": [0, 2, 4], "C": [5, 0, 2]}) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you start this test with a comment referencing the GH issue. E.g. see the test immediately below for an example. |
||
ax = df.plot.bar(stacked=True) | ||
ax.bar_label(ax.containers[-1]) | ||
expected = [8.0, 2.0, 7.0] | ||
result = [text.xy[1] for text in ax.texts] | ||
tm.assert_almost_equal(result, expected) | ||
plt.close("all") | ||
|
||
@pytest.mark.parametrize("idx", [Index, pd.CategoricalIndex]) | ||
def test_bar_categorical(self, idx): | ||
# GH 13019 | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This note should be move to v3.0.0.rst.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2.3.0 is a "special" release in that we are not doing it from the main branch. We are only backporting certain PRs to the 2.3.x branch.