Fix: b2CollideSegmentAndCapsule should pass manifold parameter to b2CollideCapsules #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
b2CollideSegmentAndCapsule
function.Explanation:
It seems to me that
b2CollideCapsules
was changed from the original in that it performs an in-place modification of themanifold
parameter, rather than creating & returning a new one. (I assume this is for performance reasons?)However, it looks like
b2CollideSegmentAndCapsule
, a function which was also modified from the original (seemingly with the same intent), does not correctly pass the manifold parameter through to theb2CollideCapsules
function it depends upon.This fixes that.
Additionally:
This also corrects an erroneous call to
manifold.clear()
with a parameter (0) which is seemingly inert and unnecessary, as this function does not accept any parameters.