Skip to content

Allow for TTL being NULL #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2016
Merged

Conversation

boekkooi
Copy link
Contributor

Currently the cache is always invalidated when no expiresAt or expiresAfter is set.

@codecov-io
Copy link

Current coverage is 100.00%

Merging #5 into master will not affect coverage as of 093c6a7

@@            master      #5   diff @@
======================================
  Files            1       1       
  Stmts           30      33     +3
  Branches         0       0       
  Methods          6       6       
======================================
+ Hit             30      33     +3
  Partial          0       0       
  Missed           0       0       

Review entire Coverage Diff as of 093c6a7

Powered by Codecov. Updated on successful CI builds.

@Nyholm
Copy link
Member

Nyholm commented Jan 22, 2016

Awesome. Thank you. Would you mind adding this test to the integration test repository?

@boekkooi
Copy link
Contributor Author

@Nyholm Done

@Nyholm
Copy link
Member

Nyholm commented Jan 22, 2016

I would be happy to merge your PRs but a test seams to be failing.

@cryptiklemur
Copy link
Member

Rebuilding

cryptiklemur added a commit that referenced this pull request Jan 23, 2016
@cryptiklemur cryptiklemur merged commit 199382d into php-cache:master Jan 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants