Skip to content

Remove the cache file when a expire item was required #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2016
Merged

Remove the cache file when a expire item was required #6

merged 1 commit into from
Jan 24, 2016

Conversation

boekkooi
Copy link
Contributor

No description provided.

@codecov-io
Copy link

Current coverage is 100.00%

Merging #6 into master will not affect coverage as of d41c926

@@            master      #6   diff @@
======================================
  Files            1       1       
  Stmts           33      34     +1
  Branches         0       0       
  Methods          6       6       
======================================
+ Hit             33      34     +1
  Partial          0       0       
  Missed           0       0

Review entire Coverage Diff as of d41c926

Powered by Codecov. Updated on successful CI builds.

@boekkooi
Copy link
Contributor Author

It looks like the test failed to you the bug fixed in PR #5

@cryptiklemur
Copy link
Member

This is still failing @boekkooi

@boekkooi
Copy link
Contributor Author

@aequasi Fixed after rebase

@Nyholm
Copy link
Member

Nyholm commented Jan 24, 2016

Cool. Thank you!

Nyholm added a commit that referenced this pull request Jan 24, 2016
@Nyholm
Merge pull request #6 from boekkooi/expire-cleanup
97266e6 
Remove the cache file when a expire item was required
@Nyholm Nyholm merged commit 97266e6 into php-cache:master Jan 24, 2016
@Nyholm
Copy link
Member

Nyholm commented Jan 24, 2016

I've tagged 0.2.1 with your fix included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@boekkooi @codecov-io @cryptiklemur @Nyholm