Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stick footer to the bottom #1204

Closed
php-coder opened this issue Jan 7, 2020 · 2 comments · Fixed by #1468
Closed

Stick footer to the bottom #1204

php-coder opened this issue Jan 7, 2020 · 2 comments · Fixed by #1468
Assignees
@demianova
Labels
area/markup area/usability impact/deploy Manual actions will be required during deployment
Milestone
0.4.5

Comments

@php-coder
Copy link
Owner

php-coder commented Jan 7, 2020 •
edited
Loading

@php-coder
Copy link
Owner Author

From my notes: use flex-shrink: 0 (and flex-grow: 1; flex: 1 0 auto;) to make a footer stick to the bottom

demianova added a commit to demianova/mystamps that referenced this issue Oct 5, 2020
@demianova
chore: keep the footer at the bottom
d2b63bd 
Fix php-coder#1204
@demianova demianova mentioned this issue Oct 5, 2020
Merged
@demianova demianova self-assigned this Oct 5, 2020
@php-coder php-coder added this to the 0.4.5 milestone Dec 2, 2020
@php-coder php-coder added the impact/deploy Manual actions will be required during deployment label Dec 27, 2020
@php-coder
Copy link
Owner Author

NOTE: don't forget to update error pages during deploy.

php-coder added a commit that referenced this issue Dec 27, 2020
@php-coder
refactor: merge sections in CSS
b3eceaa 
Should be in 27b8d25 commit.

Address to #1204
php-coder added a commit that referenced this issue Dec 27, 2020
@php-coder
chore: keep the footer at the bottom on more pages
0ad4b56 
Should be in 27b8d25 commit.

Address to #1204
@php-coder php-coder mentioned this issue Jan 7, 2021
Closed
php-coder added a commit that referenced this issue Jan 7, 2021
@php-coder
fix: an alert message for already authenticated user is shown on the …
5a4949e 
…top again on register, activation and authentication pages

Correction for 27b8d25 commit (#1204).

Fix #1486
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@demianova demianova

Labels
area/markup area/usability impact/deploy Manual actions will be required during deployment
Projects
None yet
Milestone
0.4.5
Development

Successfully merging a pull request may close this issue.

Keep the footer at the bottom demianova/mystamps
2 participants
@php-coder @demianova