Skip to content

Keep the footer at the bottom #1468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 27, 2020
Merged

Keep the footer at the bottom #1468

merged 1 commit into from
Dec 27, 2020

Conversation

demianova
Copy link
Contributor

Fix #1204

@demianova demianova requested a review from php-coder as a code owner October 5, 2020 15:40
@mystamps-bot
Copy link

mystamps-bot commented Oct 5, 2020 •
edited
Loading

1 Message
📖 @demianova thank you for the PR! All quality checks have been passed! Next step is to wait when @php-coder will review this code

Generated by 🚫 Danger

@demianova demianova force-pushed the gh1204_sticky_footer branch from d2b63bd to 27b8d25 Compare December 27, 2020 07:14
php-coder
php-coder reviewed Dec 27, 2020
View reviewed changes
Copy link
Owner

@php-coder php-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some more files that we should modify as well:

$ git grep -L 'id="content"' src/main/webapp/WEB-INF/views                                                                                                                                             16:24
src/main/webapp/WEB-INF/views/collection/estimation.html
src/main/webapp/WEB-INF/views/collection/info.html
src/main/webapp/WEB-INF/views/series/search_result.html
src/main/webapp/WEB-INF/views/site/events.html

src/main/config/nginx/503.en.html
flex-direction: column;
}
#content {
flex-grow: 1;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and in other places: we should add this property into the existing section above.

@php-coder php-coder merged commit 27b8d25 into php-coder:master Dec 27, 2020
@php-coder
Copy link
Owner

All my comments have beed addressed in b3eceaa and 0ad4b56 commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@php-coder php-coder php-coder left review comments

Assignees
No one assigned
Labels
resolution/merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stick footer to the bottom
3 participants
@demianova @mystamps-bot @php-coder