Series sales form: buyer and seller must be different

[php-coder]

Steps to reproduce:

• login as admin
• open page with series info
• fill series sales form with similar seller/buyer

Expected result:

• error should be shown

Actual result:

• form submitted successfully

Tech debt for: fe9f30d (#198)

[php-coder]

@Smetanin I'm suggesting you to work on this issue. If you're agree then assign it to yourself and add label in-progress.

The first step will be to reproduce validation issue. After that you need to write a validator to fix the issue. Actually, looks like that we already have similar validator that could be re-used. Look at FieldsMismatch and FieldsMismatchValidator

This is work flow instruction: https://github.com/php-coder/mystamps/wiki/dev_quick_start_continue

If you want some theory about validation, here are the links to documentation:

• Creating custom constraints
• Java Bean Validation Basics

[php-coder]

Here is also example for how to use FieldsMismatch validator:

mystamps/src/main/java/ru/mystamps/web/feature/account/ActivateAccountForm.java

Lines 33 to 45 in d425827

	@FieldsMismatch(
	first = "login",
	second = "password",
	message = "{password.login.match}",
	groups = ActivateAccountForm.FormChecks.class
	)
	@FieldsMatch(
	first = "password",
	second = "passwordConfirmation",
	message = "{password.mismatch}",
	groups = ActivateAccountForm.FormChecks.class
	)
	public class ActivateAccountForm implements ActivateAccountDto {

[KrivenkoAlexander]

@php-coder could you advise me where i can find this page * open page with series info ?
Do i right understand that this is the form

And we can't have the similar sales, right ? The example of bad case is : I created the two similar sales with Eicca Toppinen and John Conor with the same sum of selling .

[php-coder]

could you advise me where i can find this page * open page with series info ?

It's /series/1 for example.

Do i right understand that this is the form

Yes, it is.

And we can't have the similar sales, right ? The example of bad case is : I created the two similar sales with Eicca Toppinen and John Conor with the same sum of selling .

We can't have a series sale where a buyer is the same as a seller. Example: we can't create a sale with Eicca Toppinen as a seller and Eicca Toppinen as a buyer at the same time.

[KrivenkoAlexander]

Thanks for answer. I started to work with this task. Could you say me , if i need to get the project with last changes, i need to start mvn spring-boot:run and this command fetch the last changes , right? If so, then i did something wrong and have to re-make my solving :) I create new Annotation + but i don't Validator and apply this to the whole class see the error message. Need to investigate more. Thanks пн, 18 февр. 2019 г. в 23:07, Slava Semushin <[email protected]>:

…

could you advise me where i can find this page * open page with series info ? It's /series/1 for example. Do i right understand that this is the form Yes, it is. And we can't have the similar sales, right ? The example of bad case is : I created the two similar sales with Eicca Toppinen and John Conor with the same sum of selling . We can't have a series sale where a buyer is the same as a seller. Example: we can't create a sale with Eicca Toppinen as a seller and Eicca Toppinen as a buyer at the same time. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#503 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKy3b21cM0olR6RkcGcj3yi-hezrXMYwks5vOwfqgaJpZM4K3klc> .

-- С уважением, Кривенко Александр! [email protected] skype wyrik88

[php-coder]

Could you say me , if i need to get the project with last changes, i need to start mvn spring-boot:run and this command fetch the last changes , right?

Yes, that command should be enough. It doesn't "fetch" anything because you already have it in a working directory. It will compile everything and run the project. In some cases, you may have to clean old compiled code first (mvn clean spring-boot:run) but it shouldn't be your case.

If so, then i did something wrong and have to re-make my solving :) I create new Annotation + but i don't Validator and apply this to the whole class see the error message.

There could be many different reasons for that.

Need to investigate more.

I'm sorry but I can't help you without seeing the code...

[KrivenkoAlexander]

Hi! I decided to write to you . I create the annotation . I made it by simple way.

[image: Annotation.png]

I created the Validator . I match here id numbers of sellers and buyers. I need to find their name , but nevertheless i can't get the result with such implementation . [image: Validator.png] And try to apply it to the class where as i understand we are gathering the data [image: SeriesFormClassImp.png] What have i missed here ? I go to the UI ( restarted it before ) and don't see anything . Could you correct my investigation and correct me , if it possible :) And i wanted to ask also where i can get the seller/buyer names? Thanks a lot . ср, 20 февр. 2019 г. в 00:32, Slava Semushin <[email protected]>:

…

Could you say me , if i need to get the project with last changes, i need to start mvn spring-boot:run and this command fetch the last changes , right? Yes, that command should be enough. It doesn't "fetch" anything because you already have it in a working directory. It will compile everything and run the project. In some cases, you may have to clean old compiled code first (mvn clean spring-boot:run) but it shouldn't be your case. If so, then i did something wrong and have to re-make my solving :) I create new Annotation + but i don't Validator and apply this to the whole class see the error message. There could be many different reasons for that. Need to investigate more. I'm sorry but I can't help you without seeing the code... — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#503 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKy3b7Xh_5JuSPlq7arge5by5nzBUbMAks5vPG2AgaJpZM4K3klc> .

-- С уважением, Кривенко Александр! [email protected] skype wyrik88

[php-coder]

@KrivenkoAlexander I don't see the images on github. Also, why not just create a branch and push it? :)

[php-coder]

And i wanted to ask also where i can get the seller/buyer names?

The names don't matter, you can use mine, for example :)

[php-coder]

I created the Validator

By the way, most likely you don't need your own validator. See #503 (comment) :

Actually, looks like that we already have similar validator that could be re-used. Look at FieldsMismatch and FieldsMismatchValidator

[KrivenkoAlexander]

Yes, i read this comment . I will re-used it. I wanted to check my solution. Nevertheless i do something wrong... because i don't see the result of my validation even with existing validator . I didn't push my code because it doesn't work and i thought that i can managed it by myself and still work with it :). Sorry for delay in the build supply. I will push the code with new branch. You can look at my mess :) . Of course, there are a lot of issues for Travis but it just to demonstration. I appreciate that you spend you time for me . Could you give me few hints and i will continue to dig deeper. Thanks a lot . чт, 21 февр. 2019 г. в 00:48, Slava Semushin <[email protected]>:

…

I created the Validator By the way, most likely you don't need your own validator. See #503 (comment) <#503 (comment)> : Actually, looks like that we already have similar validator that could be re-used. Look at FieldsMismatch <https://github.com/php-coder/mystamps/blob/88979cd77fb94ea8afec8b398d33a1f44983ff18/src/main/java/ru/mystamps/web/validation/jsr303/FieldsMismatch.java> and FieldsMismatchValidator <https://github.com/php-coder/mystamps/blob/88979cd77fb94ea8afec8b398d33a1f44983ff18/src/main/java/ru/mystamps/web/validation/jsr303/FieldsMismatchValidator.java> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#503 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKy3b2_ruY0Yqu3t276eg-zBtq6EG4Baks5vPcK3gaJpZM4K3klc> .

-- С уважением, Кривенко Александр! [email protected] skype wyrik88

[KrivenkoAlexander]

Please, no worries about my touching of other parts of your code . I played around to got understanding of the project . I will rolling-back everything when catch the idea and done the task correctly. I'v gone to re-read Spring / Spring MVC again. :) Thanks чт, 21 февр. 2019 г. в 17:28, Alexander Krivenko <[email protected]>:

…

Yes, i read this comment . I will re-used it. I wanted to check my solution. Nevertheless i do something wrong... because i don't see the result of my validation even with existing validator . I didn't push my code because it doesn't work and i thought that i can managed it by myself and still work with it :). Sorry for delay in the build supply. I will push the code with new branch. You can look at my mess :) . Of course, there are a lot of issues for Travis but it just to demonstration. I appreciate that you spend you time for me . Could you give me few hints and i will continue to dig deeper. Thanks a lot . чт, 21 февр. 2019 г. в 00:48, Slava Semushin ***@***.***>: > I created the Validator > > By the way, most likely you don't need your own validator. See #503 > (comment) > <#503 (comment)> > : > > Actually, looks like that we already have similar validator that could be > re-used. Look at FieldsMismatch > <https://github.com/php-coder/mystamps/blob/88979cd77fb94ea8afec8b398d33a1f44983ff18/src/main/java/ru/mystamps/web/validation/jsr303/FieldsMismatch.java> > and FieldsMismatchValidator > <https://github.com/php-coder/mystamps/blob/88979cd77fb94ea8afec8b398d33a1f44983ff18/src/main/java/ru/mystamps/web/validation/jsr303/FieldsMismatchValidator.java> > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#503 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AKy3b2_ruY0Yqu3t276eg-zBtq6EG4Baks5vPcK3gaJpZM4K3klc> > . > -- С уважением, Кривенко Александр! ***@***.*** skype wyrik88

-- С уважением, Кривенко Александр! [email protected] skype wyrik88

[0pdd]

@php-coder the puzzle #1008 is still not solved.

[0pdd]

@php-coder the only puzzle #1008 is solved here.