str_split returns an empty array since PHP 8.2
#1544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herndlm
force-pushed
the
str-split-empty-array-return
branch
from
b6dd598 to
62d7668
Compare
herndlm
force-pushed
the
str-split-empty-array-return
branch
from
62d7668 to
fa736ff
Compare
|
Perfect, thank you :) |
BackEndTea
reviewed
Jul 25, 2022
| */ | ||
|
|
||
| /** | ||
| * This contains the information needed to convert the function signatures for php 8.0 to php 7.4 (and vice versa) |
There was a problem hiding this comment.
I think this should be 8.2 right?
And is this the difference between 7.4 and 8.2, or between 8.1 and 8.2?
There was a problem hiding this comment.
Yeah, see PR description :) UPDATE: and it is the difference between 8.1 and 8.2, yes.
There was a problem hiding this comment.
@ondrejmirtes should the delta files all (except the original one where this was copied over) updated in that regard?
There was a problem hiding this comment.
I don't care, I never read that comment :) The filename says it all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: php/php-src#8945
See also https://3v4l.org/XfZO4 and https://3v4l.org/XfZO4/rfc#vgit.master
I never touched the delta files, is this correct like this? One of the tests at least seems to verify it. And the comments in that file are obviously outdated, but I did not touch them because they're like that in other delta files as well.
UPDATE: sorry, was doing too many things at once and forgot to cleanly run make again.. I thought I could avoid nested ternaries with the match expression 😅