Fix table cell white border artifact #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployment fails caused by server downtime. Similar broken task https://circleci.com/gh/plotly/dash-sample-apps/4120 |
Marc-Andre-Rivet
suggested changes
Jul 29, 2019
There was a problem hiding this comment.
While this change is technically accurate, as we discussed, I think this should be fixed in the table itself.
Removing the style below should have (1) have no undesired side-effect on default styling for most reasonable usage scenarios, (2) officialize at the table level the fix you are proposing for your app :) See: https://github.com/plotly/dash-table/blob/master/src/dash-table/components/Table/Table.less#L247
|
Fix in plotly/dash-table#521 |
ycaokris
changed the title
Marc-Andre-Rivet
approved these changes
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
In dash-table==0.4.2, background color of table-row is set to be white, and overwrites border color at different zooming ratio in presence of css rule as {"selector": "td", "rule": "border: none !important;"}.
Fixed by setting it transparent.