Skip to content
This repository was archived by the owner on Jun 4, 2024. It is now read-only.

Remove pre-defined background color for table row #521

Merged
merged 2 commits into from
Jul 30, 2019

Conversation

ycaokris
Copy link
Contributor

Remove default tr background color.

@chriddyp chriddyp temporarily deployed to dash-table-review-pr-521 July 29, 2019 21:20 Inactive
Copy link
Contributor

@Marc-Andre-Rivet Marc-Andre-Rivet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ycaokris No impact on the tests so this is 👍

Could you please add an entry in the changelog file under the [Unreleased] > Fixed sub-section?

Something similar to:

[#521](https://github.com/plotly/dash-table/pull/521)
- Fixed white line artifacts when rendering the table with browser zoom different from 100%

Copy link
Contributor

@Marc-Andre-Rivet Marc-Andre-Rivet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 💃

@ycaokris ycaokris merged commit e90fa76 into master Jul 30, 2019
@ycaokris ycaokris deleted the remove-tr-bg-color branch July 30, 2019 18:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dash-type-bug Something isn't working as intended size: 0.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants