This repository was archived by the owner on Jun 4, 2024. It is now read-only.
Fix sticky behavior in Safari #525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcjohnson
reviewed
Aug 2, 2019
| @@ -436,6 +437,10 @@ | |||
| background-color: rgb(250, 250, 250); | |||
| } | |||
|
|
|||
| .dash-spreadsheet-inner td { | |||
| background-color: white; | |||
| } | |||
There was a problem hiding this comment.
Does this have a visual impact?
There was a problem hiding this comment.
No. A style was applied on tr and was removed which caused issues with fixed columns (columns content was visible as it was scrolled under the fixed ones). Adding it back on td instead.. just because that way it's on cells.. and since everything is otherwise applied on cells, ever so slightly cleaner. There's no real difference between applying that style on tr or td in the end.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alinastarkov found
-webkit-sticky, just adding it and fixing a (would be) regression on fixed columns (when transparent)