Skip to content
This repository was archived by the owner on Jun 4, 2024. It is now read-only.

Fix sticky behavior in Safari #525

Merged
merged 3 commits into from
Aug 2, 2019
Merged

Fix sticky behavior in Safari #525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f51378c
webkit-sticky
Aug 2, 2019
6a927ce
cahngelog entry
Aug 2, 2019
f24c1e5
Merge branch 'master' into 259-sticky-safari
alinastarkov Aug 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ between two tables within the same tab.
reset the filter for the affected column(s)

### Fixed
[#259](https://github.com/plotly/dash-table/issues/259)
- Fixed columns `sticky` on Safari

[#491](https://github.com/plotly/dash-table/issues/491)
- Fixed inconsistent behaviors when editing cell headers

Expand Down
5 changes: 5 additions & 0 deletions src/dash-table/components/Table/Table.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,7 @@
flex: 0 0 auto;
left: 0;
position: sticky;
position:-webkit-sticky;
z-index: 400;
}

Expand Down Expand Up @@ -436,6 +437,10 @@
background-color: rgb(250, 250, 250);
}

.dash-spreadsheet-inner td {
background-color: white;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this have a visual impact?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. A style was applied on tr and was removed which caused issues with fixed columns (columns content was visible as it was scrolled under the fixed ones). Adding it back on td instead.. just because that way it's on cells.. and since everything is otherwise applied on cells, ever so slightly cleaner. There's no real difference between applying that style on tr or td in the end.


.sort {
cursor: pointer;
float: left;
Expand Down