Fix test regressions related to dcc.Graph changes #1066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marc-Andre-Rivet
changed the title
alexcjohnson
approved these changes
Jan 6, 2020
There was a problem hiding this comment.
💃 I was about to comment about the weird usage in tests/integration/test_render.py before realizing that it's not using dash.testing yet... OK for now, but if we need any more substantial maintenance than this we should finish the conversion. Actually perhaps move this test to dcc #1031
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to dcc.Graph in plotly/dash-core-components#706 are impacting tests only defined / run in the Dash repository. As the PR did not involve any changes outside of DCC, the test failures were only detected when the PR was merged and dash later modified.