Skip to content

Fix some build errors not failing build. #2474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 21, 2023
Merged

Fix some build errors not failing build. #2474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
325ef52
Fix lint.black command.
T4rk1n Mar 21, 2023
2c034af
Fail process on extract elements errors.
T4rk1n Mar 21, 2023
374c346
Merge branch 'dev' into fix-2220
T4rk1n Mar 27, 2023
f775777
Merge branch 'dev' into fix-2220
T4rk1n Apr 20, 2023
e433f52
Merge branch 'dev' into fix-2220
T4rk1n Apr 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/dash-core-components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"private::format.black": "black dash_core_components_base/ tests/ setup.py",
"private::format.eslint": "eslint src --fix",
"private::format.prettier": "prettier --config .prettierrc --write src/**/*.js",
"private::lint.black": "if [[ ${PYVERSION:-python39} != python36 ]]; then black --check dash_core_components_base/ tests/ setup.py; fi",
"private::lint.black": "node -e \"if ((process.env.PYVERSION || 'python39') !== 'python36'){process.exit(1)} \" || black --check dash_core_components_base/ tests/ setup.py",
"private::lint.eslint": "eslint src",
"private::lint.flake8": "flake8 --exclude=dash_core_components,node_modules,venv",
"private::lint.prettier": "prettier --config .prettierrc src/**/*.js --list-different",
Expand Down
6 changes: 4 additions & 2 deletions components/dash-html-components/scripts/extract-elements.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,8 @@ function extractElements($) {

request(refUrl, (error, response, html) => {
if (error) {
throw error;
console.error(error);
process.exit(-1);
}
const $ = cheerio.load(html);
const elements = extractElements($);
Expand All @@ -79,11 +80,12 @@ request(refUrl, (error, response, html) => {
catch(e) {
console.log('no previous elements found');
}
throw new Error(
console.error(
'Unexpected number of elements extracted from ' + refUrl +
' - Found ' + elements.length + ' but expected ' + expectedElCount +
' Check the output and edit expectedElCount if this is intended.'
);
process.exit(-1);
}
const out = elements.join('\n');

Expand Down
2 changes: 1 addition & 1 deletion components/dash-table/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"private::format.black": "black dash_table_base tests",
"private::lint.ts": "eslint ./src ./tests",
"private::lint.flake": "flake8 dash_table_base tests",
"private::lint.black": "if [[ ${PYVERSION:-python39} != python36 ]]; then black --check dash_table_base tests; fi",
"private::lint.black": "node -e \"if ((process.env.PYVERSION || 'python39') !== 'python36'){process.exit(1)} \" || black --check dash_table_base tests",
"private::lint.prettier": "prettier --config .prettierrc \"{src,tests,demo}/**/*.{js,ts,tsx}\" --list-different",
"private::test.python": "python -m unittest tests/unit/format_test.py",
"private::test.unit": "karma start karma.conf.js --single-run",
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"private::build.components": "python dash/development/update_components.py 'all'",
"private::cibuild.renderer": "cd dash/dash-renderer && renderer build",
"private::build.renderer": "cd dash/dash-renderer && renderer build",
"private::lint.black": "if [[ ${PYVERSION:-python39} != python36 ]]; then black dash tests --exclude metadata_test.py --check; fi",
"private::lint.black": "node -e \"if ((process.env.PYVERSION || 'python39') !== 'python36'){process.exit(1)} \" || black dash tests --exclude metadata_test.py --check",
"private::lint.flake8": "flake8 --exclude=metadata_test.py dash tests",
"private::lint.pylint-dash": "PYLINTRC=${PYLINTRC:=.pylintrc39} && pylint dash setup.py --rcfile=$PYLINTRC",
"private::lint.pylint-tests": "PYLINTRC=${PYLINTRC:=.pylintrc39} && pylint tests/unit tests/integration -d all --rcfile=$PYLINTRC",
Expand Down