Dropdown menu max height fix #2892
Merged
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… by the DataTable styling when it is added to the layout. Added test for checking this as well
aGitForEveryone
requested review from
alexcjohnson,
T4rk1n and
ndrezn
as code owners
|
Thanks @ann-marie-ward for the help with setting up this PR (and creating the fix) |
Put the change in the wrong place in the change log. Corrected the change log entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2529
closes #2225
When a
dash_table.DataTableis added to the dashboard (can be an empty table as well), css stylings are added to the Dash tool (see demonstration in #2529). These stylings override themax-heightstyling defined for the dropdown component, overriding the value set by themaxHeightproperty indcc.Dropdown.This fix changes the class names to which the css style is applied, so that the custom style set by
Dropdown.csshas higher priority than thedash_table.DataTablestyling.Contributor Checklist
optionals
CHANGELOG.md