Skip to content

Dropdown menu max height fix #2892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 21, 2024
Merged

Dropdown menu max height fix #2892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ecc9089
Fixed dropdown menu max height styling such that it isn't overwritten…
aGitForEveryone Jun 17, 2024
d99009a
Added changelog entry
aGitForEveryone Jun 17, 2024
98e343d
Put the change log entry in the correct place in the file
aGitForEveryone Jun 18, 2024
c655c76
Merge branch 'dev' into dropdown-menu-max-height-fix
T4rk1n Jun 18, 2024
3f446f4
Merge branch 'dev' into dropdown-menu-max-height-fix
T4rk1n Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ This project adheres to [Semantic Versioning](https://semver.org/).

## Fixed

- [#2892](https://github.com/plotly/dash/pull/2860) Fix ensures dcc.Dropdown menu maxHeight option works with Datatable. Fixes [#2529](https://github.com/plotly/dash/issues/2529) [#2225](https://github.com/plotly/dash/issues/2225)
- [#2896](https://github.com/plotly/dash/pull/2896) The tabIndex parameter of Div can accept number or string type. Fixes [#2891](https://github.com/plotly/dash/issues/2891)

## [2.17.1] - 2024-06-12
Expand Down
3 changes: 2 additions & 1 deletion components/dash-core-components/src/components/css/Dropdown.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
.dash-dropdown .Select-menu-outer {
z-index: 1000;
max-height: none;
}

.dash-dropdown .Select-menu, .Select-menu-outer {
.dash-dropdown .Select-menu {
max-height: none;
}
5 changes: 4 additions & 1 deletion components/dash-core-components/tests/integration/dropdown/test_visibility.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,10 @@ def test_ddvi001_fixed_table(dash_duo):
def test_ddvi002_maxHeight(dash_duo):
app = Dash(__name__)
app.layout = Div(
[Dropdown([str(i) for i in range(100)], "1", id="dropdown", maxHeight=800)]
[
DataTable(), # ensure datatable css does not override maxHeight #2529
Dropdown([str(i) for i in range(100)], "1", id="dropdown", maxHeight=800),
]
)

dash_duo.start_server(app)
Expand Down