-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Generalized persistence #903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 16 commits
7a21285
b737a3f
6509121
42428a6
78df979
83b8cd3
cb179c9
b4ebb51
3b56686
5ff00cf
690b0a3
3669df6
15ca0e5
c9230f5
abde83f
4b11f07
0626ea9
ba8d5ba
09b9393
5fa4d55
53ab7c5
118547f
130a857
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -55,10 +55,14 @@ jobs: | |
pylint tests/unit tests/integration/devtools tests/integration/renderer tests/integration/dash_assets -d all -e C0410,C0411,C0412,C0413,W0109 | ||
cd dash-renderer && npm install --ignore-scripts && npm run lint:test && npm run format:test | ||
- run: | ||
name: 🔎 Unit Tests | ||
name: 🐍 Python Unit Tests | ||
command: | | ||
. venv/bin/activate | ||
PYTHONPATH=~/dash/tests/assets pytest tests/unit | ||
- run: | ||
name: ☕ JS Unit Tests | ||
command: | | ||
cd dash-renderer && npm run test:js | ||
|
||
"lint-unit-36": | ||
<<: *lint-unit | ||
|
@@ -92,6 +96,7 @@ jobs: | |
command: | | ||
sudo pip install --upgrade virtualenv | ||
python -m venv venv || virtualenv venv && . venv/bin/activate | ||
sed -i '' '/dash/d' requires-install.txt | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🐧 |
||
pip install -e . -r requires-install.txt -r requires-dev.txt -r requires-testing.txt --quiet | ||
- save_cache: | ||
key: dep-{{ checksum "ver.txt" }}-{{ checksum "requires-dev.txt" }}-{{ checksum "requires-install.txt" }}-{{ checksum "requires-testing.txt" }} | ||
|
@@ -152,7 +157,7 @@ jobs: | |
name: ️️🏗️ build misc | ||
command: | | ||
. venv/bin/activate && pip install --upgrade -e . --quiet && mkdir packages | ||
git clone --depth 1 https://github.com/plotly/dash-table.git | ||
git clone --depth 1 -b persistence https://github.com/plotly/dash-table.git | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @byronz there seems to be something funny about how these built packages get picked up by the next step. The first time I ran these tests it looked like they got the old Perhaps something funny about having the two steps |
||
cd dash-table && npm install --ignore-scripts && npm run build && python setup.py sdist && mv dist/* ../packages/ && cd .. | ||
git clone --depth 1 https://github.com/plotly/dash-html-components.git | ||
cd dash-html-components && npm install --ignore-scripts && npm run build && python setup.py sdist && mv dist/* ../packages/ && cd .. | ||
|
@@ -262,4 +267,4 @@ workflows: | |
- "test-27": | ||
requires: | ||
- build-core-27 | ||
- build-misc-27 | ||
- build-misc-27 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,4 @@ | ||
{ | ||
"presets": ["es2015", "react", "stage-2"], | ||
"env": { | ||
"development": { | ||
"presets": ["es2015", "react", "stage-2"], | ||
"plugins": [ | ||
["transform-es2015-modules-commonjs-simple", { | ||
"noMangle": true | ||
}] | ||
] | ||
} | ||
} | ||
"presets": ["@babel/preset-env", "@babel/preset-react"], | ||
"plugins": ["@babel/plugin-proposal-object-rest-spread"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not absolutely 100% certain but I don't think the spread still needs to be set explicitly. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not strictly necessary but while updating the toolchain, might as well move away from the To do so, remove babel/polyfill from package deps, add
and remove babel/polyfill from the renderer's webpack entrypoint. core-js 3 is a more modular implementation than v2, with better support for es2018 features (v2 has been on feature freeze for a long time now) and There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for the hints! Confirmed, |
||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,181 @@ | ||
// For a detailed explanation regarding each configuration property, visit: | ||
// https://jestjs.io/docs/en/configuration.html | ||
|
||
module.exports = { | ||
// All imported modules in your tests should be mocked automatically | ||
// automock: false, | ||
|
||
// Stop running tests after the first failure | ||
// bail: false, | ||
|
||
// Respect "browser" field in package.json when resolving modules | ||
// browser: false, | ||
|
||
// The directory where Jest should store its cached dependency information | ||
// cacheDirectory: "/var/folders/8m/wrr89jfx5kg5xhp7q2127bcc0000gn/T/jest_dx", | ||
|
||
// Automatically clear mock calls and instances between every test | ||
clearMocks: true, | ||
|
||
// Indicates whether the coverage information should be collected while executing the test | ||
// collectCoverage: false, | ||
|
||
// An array of glob patterns indicating a set of files for which coverage information should be collected | ||
// collectCoverageFrom: null, | ||
|
||
// The directory where Jest should output its coverage files | ||
coverageDirectory: "coverage", | ||
|
||
// An array of regexp pattern strings used to skip coverage collection | ||
// coveragePathIgnorePatterns: [ | ||
// "/node_modules/" | ||
// ], | ||
|
||
// A list of reporter names that Jest uses when writing coverage reports | ||
// coverageReporters: [ | ||
// "json", | ||
// "text", | ||
// "lcov", | ||
// "clover" | ||
// ], | ||
|
||
// An object that configures minimum threshold enforcement for coverage results | ||
// coverageThreshold: null, | ||
|
||
// Make calling deprecated APIs throw helpful error messages | ||
// errorOnDeprecated: false, | ||
|
||
// Force coverage collection from ignored files usin a array of glob patterns | ||
// forceCoverageMatch: [], | ||
|
||
// A path to a module which exports an async function that is triggered once before all test suites | ||
// globalSetup: null, | ||
|
||
// A path to a module which exports an async function that is triggered once after all test suites | ||
// globalTeardown: null, | ||
|
||
// A set of global variables that need to be available in all test environments | ||
// globals: {}, | ||
|
||
// An array of directory names to be searched recursively up from the requiring module's location | ||
// moduleDirectories: [ | ||
// "node_modules" | ||
// ], | ||
|
||
// An array of file extensions your modules use | ||
// moduleFileExtensions: [ | ||
// "js", | ||
// "json", | ||
// "jsx", | ||
// "node" | ||
// ], | ||
|
||
// A map from regular expressions to module names that allow to stub out resources with a single module | ||
moduleNameMapper: { | ||
"\\.(css|less)$": "identity-obj-proxy" | ||
}, | ||
|
||
// An array of regexp pattern strings, matched against all module paths before considered 'visible' to the module loader | ||
// modulePathIgnorePatterns: [], | ||
|
||
// Activates notifications for test results | ||
// notify: false, | ||
|
||
// An enum that specifies notification mode. Requires { notify: true } | ||
// notifyMode: "always", | ||
|
||
// A preset that is used as a base for Jest's configuration | ||
// preset: null, | ||
|
||
// Run tests from one or more projects | ||
// projects: null, | ||
|
||
// Use this configuration option to add custom reporters to Jest | ||
// reporters: undefined, | ||
|
||
// Automatically reset mock state between every test | ||
// resetMocks: false, | ||
|
||
// Reset the module registry before running each individual test | ||
// resetModules: false, | ||
|
||
// A path to a custom resolver | ||
// resolver: null, | ||
|
||
// Automatically restore mock state between every test | ||
// restoreMocks: false, | ||
|
||
// The root directory that Jest should scan for tests and modules within | ||
// rootDir: null, | ||
|
||
// A list of paths to directories that Jest should use to search for files in | ||
roots: [ | ||
"<rootDir>/tests" | ||
], | ||
|
||
// Allows you to use a custom runner instead of Jest's default test runner | ||
// runner: "jest-runner", | ||
|
||
// The paths to modules that run some code to configure or set up the testing environment before each test | ||
// setupFiles: ['<rootDir>/tests/setupTests.js'], | ||
|
||
// The path to a module that runs some code to configure or set up the testing framework before each test | ||
// setupTestFrameworkScriptFile: null, | ||
|
||
// A list of paths to snapshot serializer modules Jest should use for snapshot testing | ||
// snapshotSerializers: [], | ||
|
||
// The test environment that will be used for testing | ||
testEnvironment: "jsdom", | ||
|
||
// Options that will be passed to the testEnvironment | ||
// testEnvironmentOptions: {}, | ||
|
||
// Adds a location field to test results | ||
// testLocationInResults: false, | ||
|
||
// The glob patterns Jest uses to detect test files | ||
testMatch: [ | ||
"**/?(*.)+(spec|test).js?(x)" | ||
], | ||
|
||
// An array of regexp pattern strings that are matched against all test paths, matched tests are skipped | ||
// testPathIgnorePatterns: [ | ||
// "/node_modules/" | ||
// ], | ||
|
||
// The regexp pattern Jest uses to detect test files | ||
// testRegex: "", | ||
|
||
// This option allows the use of a custom results processor | ||
// testResultsProcessor: null, | ||
|
||
// This option allows use of a custom test runner | ||
// testRunner: "jasmine2", | ||
|
||
// This option sets the URL for the jsdom environment. It is reflected in properties such as location.href | ||
// testURL: "http://localhost", | ||
|
||
// Setting this value to "fake" allows the use of fake timers for functions such as "setTimeout" | ||
// timers: "real", | ||
|
||
// A map from regular expressions to paths to transformers | ||
// transform: null, | ||
|
||
// An array of regexp pattern strings that are matched against all source file paths, matched files will skip transformation | ||
// transformIgnorePatterns: [ | ||
// "/node_modules/" | ||
// ], | ||
|
||
// An array of regexp pattern strings that are matched against all modules before the module loader will automatically return a mock for them | ||
// unmockedModulePathPatterns: undefined, | ||
|
||
// Indicates whether each individual test should be reported during the run | ||
// verbose: null, | ||
|
||
// An array of regexp patterns that are matched against all source file paths before re-running tests in watch mode | ||
// watchPathIgnorePatterns: [], | ||
|
||
// Whether to use watchman for file crawling | ||
// watchman: true, | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@byronz as discussed - to prevent the possible double-install of the rest of dash core, since we're going to be building and installing these from specific branches/commits anyway (to resolve the test failures https://github.com/plotly/dash/pull/903/files#r323830675)